feat(skore): Add params_search_reports_ as a list of CrossValidationReport#2125
Draft
glemaitre wants to merge 4 commits intoprobabl-ai:mainfrom
Draft
feat(skore): Add params_search_reports_ as a list of CrossValidationReport#2125glemaitre wants to merge 4 commits intoprobabl-ai:mainfrom
params_search_reports_ as a list of CrossValidationReport#2125glemaitre wants to merge 4 commits intoprobabl-ai:mainfrom
Conversation
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2127
This PR is an exploration of what is required to store the results of hyperparmeters search done with a
GridSearchCVorRandomizedSearchCVvia aCrossValidationReport. Basically, we want to avoid to have to refit anything that already have been fitted with scikit-learn.In short:
cv_results_ComparisonReportofCrossValidationReportfrom thecv_results_.The benefit of building upon
ComparisonReportandCrossValidationReportis that we already have the structure to just send those types of reports in the skore-hub.TODO:
Thoughts:
We should thing further regarding the type of comparison one tries to achieve when comparing results from an hyperparameter search and when comparing different model. Usually, hyperparameters search is related to have a single model and explore the parameter while comparing different models makes that there is nothing in common, potentially.
Therefore, the
ComparisonReportcould have a couple of functionality dedicated to hyper parameters search that could be activated when passing the results of a cross-validation search.