chore(skore): Switch from mypy to ty

.github/workflows/lint.yml

@@ -47,4 +47,4 @@ jobs:
           pre-commit run --all-files typos
           pre-commit run --all-files nbstripout
           pre-commit run --all-files ruff-check
-          pre-commit run --all-files mypy
+          pre-commit run --all-files ty

.pre-commit-config.yaml

@@ -32,47 +32,25 @@ repos:
       - id: ruff-format
         files: ^((skore|skore-hub-project|skore-local-project)/(hatch|src|tests))|(examples)/
 
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.19.1
+  - repo: local
     hooks:
-
-      - id: mypy
-        pass_filenames: false
-        alias: mypy-skore
-        name: mypy skore/
-        files: ^skore/
-        args: [--config-file=skore/pyproject.toml, skore]
-        additional_dependencies:
-          # from dependencies
-          - IPython
-          - anywidget
-          - ipywidgets
-          - joblib
-          - matplotlib
-          - numpy
-          - pandas
-          - plotly
-          - rich
-          - scikit-learn
-          - skrub
-          - seaborn
-          # from test dependencies
-          - polars
-          - pyarrow
-          - scipy-stubs
-
-      - id: mypy
-        pass_filenames: false
-        alias: mypy-skore-hub-project
-        name: mypy skore-hub-project/
-        files: ^skore-hub-project/
-        args: [--config-file=skore-hub-project/pyproject.toml, skore-hub-project]
-        additional_dependencies: [skore, blake3, httpx, orjson, pandas-stubs, pydantic]
-
-      - id: mypy
-        pass_filenames: false
-        alias: mypy-skore-local-project
-        name: mypy skore-local-project/
-        files: ^skore-local-project/
-        args: [--config-file=skore-local-project/pyproject.toml, skore-local-project]
-        additional_dependencies: [skore]
+    - id: ty
+      alias: ty-skore
+      name: ty skore/
+      entry: uv run ty check --project skore
+      language: system
+      pass_filenames: false
+
+    - id: ty
+      alias: ty-skore-hub-project
+      name: ty skore-hub-project/
+      entry: uv run ty check --project skore-hub-project
+      language: system
+      pass_filenames: false
+
+    - id: ty
+      alias: ty-skore-local-project
+      name: ty skore-local-project/
+      entry: uv run ty check --project skore-local-project
+      language: system
+      pass_filenames: false

skore-hub-project/pyproject.toml

@@ -109,18 +109,18 @@ convention = "numpy"
 [tool.ruff.lint.per-file-ignores]
 "tests/*" = ["D"]
 
-[tool.mypy]
-exclude = ["hatch/", "tests/"]
-strict = true
-
-[[tool.mypy.overrides]]
-follow_untyped_imports = true
-module = ["skore.*"]
-
-[[tool.mypy.overrides]]
-ignore_missing_imports = true
-module = [
-  "joblib.*",
-  "scipy.*",
-  "sklearn.*",
+[tool.ty.src]
+exclude = ["hatch/**", "tests/**"]
+
+[tool.ty.analysis]
+allowed-unresolved-imports = [
+  "joblib.**",
+  "scipy.**",
+  "sklearn.**",
 ]
+
+[[tool.ty.overrides]]
+include = ["skore/**"]
+
+[tool.ty.overrides.analysis]
+respect-type-ignore-comments = true

skore-hub-project/src/skore_hub_project/artifact/artifact.py

@@ -3,6 +3,7 @@
 from abc import ABC, abstractmethod
 from contextlib import AbstractContextManager, nullcontext
 from functools import cached_property
+from typing import cast
 
 from pydantic import BaseModel, ConfigDict, Field, computed_field
 
@@ -55,7 +56,7 @@ def content_to_upload(self) -> Generator[str, None, None]:
                 yield "<str>"
         """
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def checksum(self) -> str | None:
         """Checksum used to identify the content of the artifact."""
@@ -65,11 +66,13 @@ def checksum(self) -> str | None:
             contextmanager = nullcontext(contextmanager)
 
         with contextmanager as content:
-            if content is not None:
-                return upload(
-                    project=self.project,
-                    content=content,
-                    content_type=self.content_type,
-                )
-
-        return None
+            if content is None:
+                return None
+
+            content = cast(str | bytes, content)
+
+            return upload(
+                project=self.project,
+                content=content,
+                content_type=self.content_type,
+            )

skore-hub-project/src/skore_hub_project/metric/metric.py

@@ -68,7 +68,7 @@ class Metric(BaseModel, ABC, Generic[Report]):
     greater_is_better: bool | None = Field(init=False)
     position: int | None = Field(init=False)
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @property
     def value(self) -> float | None:
         """The value of the metric."""

skore-hub-project/src/skore_hub_project/report/cross_validation_report.py

@@ -158,13 +158,13 @@ def model_post_init(self, _: Any) -> None:  # noqa: D102
             self.__sample_to_class_index = None
             self.__classes = None
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def dataset_size(self) -> int:
         """Size of the dataset."""
         return len(self.report.X)
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def splitting_strategy(self) -> dict[str, Any]:
         """
@@ -240,21 +240,21 @@ def splitting_strategy(self) -> dict[str, Any]:
 
     groups: list[int] | None = None
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @property
     def class_names(self) -> list[str] | None:
         """In classification, the class names of the dataset used in the report."""
         return self.__classes
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def target_range(self) -> list[float] | None:
         """The range of the target values of the dataset used in the report."""
         if self.__classes:
             return None
         return [float(self.report.y.min()), float(self.report.y.max())]
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def estimators(self) -> list[EstimatorReportPayload]:
         """The estimators used in each split by the report in a payload format."""

skore-hub-project/src/skore_hub_project/report/report.py

@@ -53,20 +53,20 @@ class ReportPayload(BaseModel, ABC, Generic[Report]):
 
     model_config = ConfigDict(frozen=True, arbitrary_types_allowed=True)
 
-    METRICS: ClassVar[tuple[type[Metric[Report]], ...]]
-    MEDIAS: ClassVar[tuple[type[Media[Report]], ...]]
+    METRICS: ClassVar[tuple[type[Metric], ...]]
+    MEDIAS: ClassVar[tuple[type[Media], ...]]
 
     project: Project = Field(repr=False, exclude=True)
     report: Report = Field(repr=False, exclude=True)
     key: str
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @property
     def estimator_class_name(self) -> str:
         """The name of the report's estimator."""
         return self.report.estimator_name_
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def dataset_fingerprint(self) -> str:
         """The hash of the targets in the test-set."""
@@ -81,13 +81,13 @@ def dataset_fingerprint(self) -> str:
             ),
         )
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @property
     def ml_task(self) -> str:
         """The type of ML task covered by the report."""
         return self.report.ml_task
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def metrics(self) -> list[Metric[Report]]:
         """
@@ -128,7 +128,7 @@ def metrics(self) -> list[Metric[Report]]:
 
         return [metric for metric in metrics if metric.value is not None]
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def medias(self) -> list[Media[Report]]:
         """
@@ -151,7 +151,7 @@ def medias(self) -> list[Media[Report]]:
 
         return payloads
 
-    @computed_field  # type: ignore[prop-decorator]
+    @computed_field
     @cached_property
     def pickle(self) -> Pickle:
         """

skore-local-project/pyproject.toml

@@ -99,17 +99,14 @@ convention = "numpy"
 [tool.ruff.lint.per-file-ignores]
 "tests/*" = ["D"]
 
-[tool.mypy]
-exclude = ["hatch/", "tests/"]
-strict = true
-
-[[tool.mypy.overrides]]
-follow_untyped_imports = true
-module = ["skore.*"]
+[tool.ty.src]
+exclude = [
+  "hatch/**",
+  "tests/**",
+]
 
-[[tool.mypy.overrides]]
-ignore_missing_imports = true
-module = [
-  "diskcache.*",
-  "joblib.*",
+[tool.ty.analysis]
+allowed-unresolved-imports = [
+  "diskcache.**",
+  "joblib.**",
 ]

skore-local-project/src/skore_local_project/storage.py

@@ -7,7 +7,7 @@
 
 from diskcache import Cache
 
-Cache = partial(Cache, size_limit=float("inf"), cull_limit=0, eviction=None)
+StorageCache = partial(Cache, size_limit=float("inf"), cull_limit=0, eviction=None)
 
 
 class DirectoryDoesNotExist(Exception):
@@ -28,7 +28,7 @@ class DiskCacheStorage:
 
     Attributes
     ----------
-    storage : Cache
+    storage : StorageCache
         The underlying diskcache Cache object.
     """
 
@@ -103,7 +103,7 @@ def __getitem__(self, key: str) -> Any:
         KeyError
             If the key is not found in the storage.
         """
-        with Cache(self.directory) as storage:
+        with StorageCache(self.directory) as storage:
             return storage[key]
 
     def __setitem__(self, key: str, value: Any) -> None:
@@ -117,7 +117,7 @@ def __setitem__(self, key: str, value: Any) -> None:
         value : Any
             The value to store.
         """
-        with Cache(self.directory) as storage:
+        with StorageCache(self.directory) as storage:
             storage[key] = value
 
     def __delitem__(self, key: str) -> None:
@@ -134,7 +134,7 @@ def __delitem__(self, key: str) -> None:
         KeyError
             If the key is not found in the storage.
         """
-        with Cache(self.directory) as storage:
+        with StorageCache(self.directory) as storage:
             del storage[key]
 
     def keys(self) -> Iterator[str]:
@@ -146,7 +146,7 @@ def keys(self) -> Iterator[str]:
         Iterator[str]
             An iterator yielding all keys in the storage.
         """
-        with Cache(self.directory) as storage:
+        with StorageCache(self.directory) as storage:
             yield from storage
 
     def values(self) -> Iterator[Any]:
@@ -158,7 +158,7 @@ def values(self) -> Iterator[Any]:
         Iterator[Any]
             An iterator yielding all values in the storage.
         """
-        with Cache(self.directory) as storage:
+        with StorageCache(self.directory) as storage:
             for key in storage:
                 yield storage[key]
 
@@ -171,7 +171,7 @@ def items(self) -> Iterator[tuple[str, Any]]:
         Iterator[tuple[str, Any]]
             An iterator yielding all (key, value) pairs in the storage.
         """
-        with Cache(self.directory) as storage:
+        with StorageCache(self.directory) as storage:
             for key in storage:
                 yield (key, storage[key])
 

skore/pyproject.toml

@@ -162,18 +162,5 @@ convention = "numpy"
 [tool.ruff.lint.per-file-ignores]
 "tests/*" = ["D"]
 
-[tool.mypy]
-exclude = ["src/skore/_externals/", "hatch/", "tests/"]
-
-[[tool.mypy.overrides]]
-ignore_missing_imports = true
-module = [
-  "ipywidgets.*",
-  "jinja2.*",
-  "joblib.*",
-  "pandas.*",
-  "plotly.*",
-  "seaborn.*",
-  "sklearn.*",
-  "skrub.*",
-]
+[tool.ty.src]
+exclude = ["hatch/**", "src/skore/_externals/**", "tests/**"]