Add DAW Controller support for various Arturia controllers #743
Conversation
|
Build for testing: |
|
Thank you very much for this contribution @soyersoyer. Unfortunately I don't have the matching hardware to test this with, but I am sure many users will find this extremely useful. Semi off topic: Do you know any good/straightforward documentation how the display and encoder on the Keystep communicates with the host over USB? It just so happens that recently I was thinking about building something the other way around (unrelated to MiniDexed), a simple microcontroller + display + encoder combination that does what a Keystep can do (e.g., to browse presets of the free Analog Lab Play), but without needing an actual Keystep. |
Well users of this specific MIDI controller maybe, but I'm really not sure about hardcoding support for just one vendor's device in MiniDexed... In that SysEx message, 0x00, 0x20, 0x6B is the Arturia SysEx Vendor ID - right? It's a little hard to tell as I didn't seem to be able to find any mention of the MIDI implementation of Arturia devices from the manufacturer themself. Do you have a link? If we were to go down this route, then I think we'd have to have some way of querying a connected device and mapping MiniDexed features to the features of the device itself rather than hard-code in specific SysEx messages in my view. Do we know what other controllers support displays and how they do it? @probonopd you weren't keen on me adding bespoke SysEx to MiniDexed to support this kind of thing between MiniDexeds, so I'm a little surprised you seem quite happy to be considering adding bespoke vendor MIDI messages other than Yamaha...? Kevin |
Do you think KeyLab? KeyStep doesn't have a display. In the MiniLab 3 there is an 'Arturia' program for Analog Lab, but I don't know how it communicates. Probably after an initial model query, the main Encoder sends relative CC-s, the other encoders send absolute CCs, the Analog lab sets the encoder values on preset change and updates the display with sysex. If you think, I can capture it. For the DAW mode, I found this:
This is a very popular controller, so I think it might be worth adding. Additional vendors may be added later.
Yes
From Arturia, No. We can send generic device inquiry with You are right, the DAWDisplayEnabled config option is too broad and should enable some auto-detection mode. |
soyersoyer
force-pushed
the
dawdisplay
branch
2 times, most recently
from
787cbe1 to
0211e16
Compare
|
Build for testing: |
|
@soyersoyer You beat me to it while planning to do the same. It works with my MiniLab3 (firmware 1.1.1). The only issue is the Dumping MIDI to console which seems not reliable. Also you don't configure the any of the available sliders, knobs to actual functions like Pan, Volume etc. Let me take a look. |
soyersoyer
force-pushed
the
dawdisplay
branch
from
0211e16 to
0b55ac6
Compare
|
I refined it a bit. Now it does a sysex inquiry and only sends sysex if it is MiniLab3 or KeyLab 3 Essential. Does this fix your MIDI issue? |
|
Build for testing: |
soyersoyer
force-pushed
the
dawdisplay
branch
from
0b55ac6 to
fd5e834
Compare
|
Build for testing: |
soyersoyer
force-pushed
the
dawdisplay
branch
from
fd5e834 to
c692205
Compare
|
Build for testing: |
soyersoyer
force-pushed
the
dawdisplay
branch
from
c692205 to
4f88b13
Compare
|
Build for testing: |
|
|
|
How should they work? Should they send CC-s to channel 1? |
soyersoyer
force-pushed
the
dawdisplay
branch
from
4f88b13 to
98788fa
Compare
|
Build for testing: |
|
Now, it maps the encoders. Also updates the encoders values at performance load from TG0. Unfortunately the pads cannot be configured to send CC-s in DAW mode, they send notes only on channel 10. What I want also:
|
soyersoyer
changed the title
soyersoyer
force-pushed
the
dawdisplay
branch
from
98788fa to
d1140e2
Compare
|
Build for testing: |
soyersoyer
force-pushed
the
dawdisplay
branch
from
d1140e2 to
9f174f6
Compare
|
I think the encoders should set the parameters based on the menu, so if the display is on the TG1, it should set the TG1 parameters, if on the performance, it should set all TG-s parameters, if it is on the effects it should set the effect parameters. I will try to make this later on a different branch. |
|
Build for testing: |
soyersoyer
force-pushed
the
dawdisplay
branch
from
9f174f6 to
bb72a25
Compare
|
What is "long press on shift the sub-menu"? @soyersoyer do you understand why the two displays might not behave identically in some situations? |
|
@probonopd : lol my sentence was badly formulated. I mean activating the display of the sub menu by a long press on shift. |
MiniLab 3 Keylab Essential KeyLab Essential mk3 KeyLab mkII based on https://github.com/PrzemekBarski/arturia-keylab-essential-mk3-programming-guide Tested on a Arturia MiniLab 3 and KeyLab mkII Keylab Essential and Keylab Essential mk3 is not tested
soyersoyer
force-pushed
the
dawdisplay
branch
from
20b9800 to
b99658c
Compare
|
Build for testing: |
Sorry, I didn't test a change, and it updated the color of the pads too many times. That's what caused the glitches. If you experience this still, please let me know.
Holding down the Shift key (CC27) will bring up an overlay menu where you can select control layouts for what the 2x4 encoders change. The available overlay menus change depending on where you are in the menu. The Main, TG, Effect, Voice, Op menus have different overlay layers. But all voice and operator settings are routed to Main / TG / Voice also, so that on one page, for example, you can set OP_EG_R1 of the 6 operators (encoder 1-6) and all of them with encoder 8. I think it's a good idea to have the overlay menu appear on the default screen as well. However, it would have to be integrated into the MiniDexed menu and I don't know if others would think it's a good idea. |
|
Thank you for your hard work ! |
|
Maybe this can be "transparent", I mean not activated on minidexed without Arturia mod ? If you select "DAWControllerEnabled=1" you have the display of the sub menus on the MiniDexed screen, otherwise not. I'm not a coder, so maybe I tell sh** ? |
|
I was thinking that it would be possible to set a MIDI CC in the config for the shift button and 8 for the encoders, and it could work with any configurable controller that has 1 button and 8 encoders. |
|
This functionality will be available here: |
|
Oh. What does this closing mean for moving the controler code into the main MiniDexed? |
|
#767 couldn't make it to MiniDexed in 2 months. Maybe probonopd doesn't want to see any vendor specific stuff in it? I don't know. #767 is a small change compared to this, so if this PR could be merged, I think it would take about 1 year to get there. Since these output zips are only available for 3 days, I'd have to do something with the code every 3 days for the next year so people can try it out here. This makes no sense. There's also no point in asking people to try the change #800, but that's not available (for most people). I don't see the reason for changing the retention days to 3 anymore, because it seems like actions from public github projects wouldn't count towards storage. e9751e6 The linked PR doesn't have a 3-day limit. soyersoyer#2 I'll always try to rebase on the main from here. |
|
Thanks for the insight :) |
Well, to be fair - just /one week/ ago there will still some updates required for this "simple" change. The hazard of having a larger user-base now for code like this is that changing code and testing new functionality is relatively easy, but reviewing those changes and testing for no side effects for existing platforms (remember this supports Pi V1,2,3,4,5,Zero, Zero 2, 400) takes time. People always come forward to test new functionality, especially when it meets an unmet need they had. But very few people come forward and confirm that everything is still fine without side effects on existing platforms. And you may recall it was I who was concerned about vendor specific code (#743 (comment)) not @probonopd who has only been very supportive of these more experimental changes. But my main concern is about longevity of support for these large changes, hence wanting to understand the implications if asked for my opinions on them. As I say, initial implementation is one thing, but it took quite a while to build up knowledge of the code base after the initial creators left, so when faced with a large body of changes (#743, #791, #790, #778, #782, #779, #777, #747, #783, #755, #750, #758), some of which didn't seem to be solving an obvious known issue, some of which were updating core libraries, and some of which were adding a significant amount of code, then we must collectively forgive the fact that volunteer maintainers (who also do this for fun) might take quite a while to catch up with what is going on. Kevin |
|
I am very sorry for the 3 days limit. I have been running out of space that GitHub grants. Still would very much like to see these contributions to be merged! |
|
What do public github projects count towards? |
|
Good question, I need to check. I just got a warning from GitHub toward end of December that I was over 90%. Edit: I think it is 1 GB across all repos of a user. And I have many repos... |
|
News:
|
|
News:
|
Not entirely sure how to read this, but my understanding is that across all my repositories, I only have 0.5 GB-months in the free tier but am at 0.79 already for January.
I interpret the sentence "Removing stored artifacts will not reduce this number, but it will lower its rate of growth." as "In order to reduce this number, you need to wait until all already-uploaded artifacts have expired, and set a shorter retention time for future artifacts" - but that's just my interpretation and might well be wrong. |
|
For me it's 0, even though I already have a few MiniDexed artifacts. I think this doesn't include public projects. If you request the usage report, you'll get a CSV where you can see how much each project is using. |
|
News:
|
|
Will the 3-day limit remain or will there be something else? |
|
Maybe we can find some alternative service where one can temporarily upload files? |
|
How much space does MiniDexed take up based on the CSV? |
|
I never managed to see the CSV. They don't give it for direct download but send it to some mail address (I don't even know which one, I seem to have too many). |
|
And if you click on the "Get Usage Report" button, it will show you where it will send the report. |
This will be available here:
https://github.com/soyersoyer/MiniDexed
This feature can be enabled in the minidexed.ini with:
Features
Controller Display, Main Encoder
The controller display in DAW mode shows the MiniDexed menu.
With the main encoder you can navigate in the menu.
The Home is the shift+Main click
Supported:
Energy efficiency
This version uses a little less power so it runs cooler.
Extra MIDI CC
MiniLab 3 features:
Encoders
By holding down shift will bring up an overlay menu, where you can see and adjust what the encoders do.
You can use the main encoder to select the current encoding page.
Short pressing the shift will show the actual values.
Holding down the shift will goes back to the normal menu.
This overlay menu is context-aware, it is different if you are in the effect menu, or in a TG menu.
If you are in a TG menu, it only affects the selected TG.
If you are in the main menu, it affects the TGs on the first TG's channel.
Main Overlay 1 (default)
Cutoff, Resonance, ReverbSend, None
PortamentoTime, Program, Vol, None
Faders: ChG 1 Vol, ChG 2 Vol, ChG 3 Vol, ChG 4 Vol
Effect Overlay
CompressorEnable, ReverbEnable, ReverbSize, ReverbHighDamp
ReverbLowDamp, ReverbLowPass, ReverbDiffusion, ReverbLevel
Main Overlay 2
Pan1, Pan2, Pan3, Pan4
Det1, Det2, Det3, Det4
Faders: TG1 Vol, TG2 Vol, TG3 Vol, TG4 Vol
Main Overlay 3
Pan5, Pan6, Pan7, Pan8
Det5, Det6, Det7, Det8
Faders: TG5 Vol, TG6 Vol, TG7 Vol, TG8 Vol
TG Overlay 1
Cutoff, Resonance, ReverbSend, MasterTune
PortamentoTime, Program, Volume, Pan
Faders: Cutoff, Resonance, ReverbSend, Volume
TG Overlay 2
MIDIChannel, None, None, PitchBendRange
PortamentoGlissando, MonoMode, None, PitchBendStep
TG Overlay 3
MWRange, MWPitch, FCRange, FCPitch
MWEGBias, MWAmplitude, FCEGBias, FCAmplitude
TG Overlay 4
BCRange, BCPitch, ATRange, ATPitch
BCEGBias, BCAmplitude, ATEGBias, ATAmplitude
Voice Overlay 1
ALGORITHM, FEEDBACK, TRANSPOSE, None,
None, None, None, None
Voice Overlay 2
PITCH_EG_R1, PITCH_EG_R2, PITCH_EG_R3, PITCH_EG_R4
PITCH_EG_L1, PITCH_EG_L2, PITCH_EG_L3, PITCH_EG_L4
Faders: PITCH_EG_L1, PITCH_EG_L2, PITCH_EG_L3, PITCH_EG_L4
Voice Overlay 3
OSC_KEY_SYNC, LFO_SPEED, LFO_DELAY, LFO_PITCH_MOD_DEP
LFO_SYNC, LFO_WAVE, LFO_PITCH_MOD_SENS, LFO_AMP_MOD_DEP
OP Overlay 1
OP_OUTPUT_LEV, OP_FREQ_COARSE, OP_FREQ_FINE, OP_OSC_DETUNE,
OP_OSC_MODE, OP_ENABLE, None, None
OP Overlay 2
OP_EG_R1, OP_EG_R2, P_EG_R3, OP_EG_R4
OP_EG_L1, OP_EG_L2, OP_EG_L3, OP_EG_L4,
Faders: OP_EG_L1, OP_EG_L2, OP_EG_L3, OP_EG_L4,
OP Overlay 3
OP_LEV_SCL_BRK_PT, OP_SCL_LEFT_DEPTH, OP_SCL_RGHT_DEPTH, OP_AMP_MOD_SENS
OP_OSC_RATE_SCALE, OP_SCL_LEFT_CURVE, OP_SCL_RGHT_CURVE, OP_KEY_VEL_SENS
In the Main overlay you can reach the TG and voice overlays also.
In the voice overlay there is a page for every OP control also, with the 6 operator and with an encoder which sets all.
Pads on Bank A
Pads on Bank B
KeyLab mkII features
Faders
DAW buttons
Track select buttons