Skip to content

PlusIcon Menu isn't closed when clicked outside and not on any MenuItem or on the Icon itself. #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umangutkarsh opened this issue Dec 9, 2023 · 5 comments
Closed

PlusIcon Menu isn't closed when clicked outside and not on any MenuItem or on the Icon itself. #2703

umangutkarsh opened this issue Dec 9, 2023 · 5 comments
Labels
Enhancement

Comments

@umangutkarsh
Copy link
Contributor

umangutkarsh commented Dec 9, 2023 •
edited
Loading

Increasing Access

This would allow users to be able to close the Menu by clicking outside anywhere on the screen also.

Feature enhancement details

Just like with the other DropDown menu options, this feature should be added in this PlusIcon also.

Steps to reproduce:

  1. Go to p5.js-web-Editor
  2. Expand the sidebar
  3. Click on PlusIcon
  4. Click outside -> The menu is not closed.
iii
@welcome Welcome
Copy link

welcome bot commented Dec 9, 2023

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Dec 9, 2023 •
edited
Loading

I have a solution for this. Working on this.

@AdityaNik
Copy link

Hey, @umangutkarsh this issue is already mentioned here #2683

@raclim
Copy link
Collaborator

raclim commented Dec 9, 2023

Yes, this has been cited already in the issue @AdityaNik mentions above! To organize and consolidate issues I'm going to close this one, but please feel free to go ahead and work on it!

@raclim raclim closed this as completed Dec 9, 2023
@umangutkarsh umangutkarsh mentioned this issue Dec 9, 2023
Closed
4 tasks
@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Dec 9, 2023 •
edited
Loading

Okay, I'll mention the PR in that issue.
Thanks for letting me know about it.

umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 13, 2023
@umangutkarsh
Merge branch 'develop' into fix/processing#2703-DropDown-closing-issue
df61f4b
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 15, 2023
@umangutkarsh
Merge branch 'develop' into fix/processing#2703-DropDown-closing-issue
4dce86d
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 16, 2023
@umangutkarsh
Merge branch 'develop' into fix/processing#2703-DropDown-closing-issue
0e6ae42
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 17, 2023
@umangutkarsh
Merge branch 'develop' into fix/processing#2703-DropDown-closing-issue
1c625d4
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Feb 10, 2024
@umangutkarsh
Merge branch 'develop' into fix/processing#2703-DropDown-closing-issue
52fc62e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop-down closing issue fixed. umangutkarsh/p5.js-web-editor
3 participants
@raclim @umangutkarsh @AdityaNik