Skip to content

Ellipsis modal is not responsive on mWeb #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PiyushChandra17 opened this issue Dec 16, 2023 · 3 comments · Fixed by #2731
Closed

Ellipsis modal is not responsive on mWeb #2730

PiyushChandra17 opened this issue Dec 16, 2023 · 3 comments · Fixed by #2731
Labels
Bug Error or unexpected behaviors

Comments

@PiyushChandra17
Copy link
Contributor

p5.js version

2.10.1

What is your operating system?

Mac OS

Web browser and version

No response

Actual Behavior

Ellipsis modal is not responsive on mWeb

ios-td

Expected Behavior

Ellipsis modal should be responsive on mWeb

Steps to reproduce

Steps:

  1. Open the editor app on mweb
  2. Tap on three dots
  3. Notice the modal is not responsive
@PiyushChandra17 PiyushChandra17 added the Bug Error or unexpected behaviors label Dec 16, 2023
@PiyushChandra17
Copy link
Contributor Author

@lindapaiste I think the recent fundraiser PR merged is causing this issue, need to investigate on this one.

aryanas159 added a commit to aryanas159/p5.js-web-editor that referenced this issue Dec 16, 2023
@aryanas159
Copy link
Contributor

@PiyushChandra17 You're right, the recently added 'fundraiser' item was causing the issue, adding a max-width fixed it, also the modal was overflowing and hiding the content in smaller screens, being able to scroll the menu will fix this issue.

raclim added a commit that referenced this issue Dec 16, 2023
fix: #2730 The navbar menu is now responsive
@raclim
Copy link
Collaborator

raclim commented Dec 16, 2023

Thanks for catching this! This is definitely on me—I should've handled the mobile nav changes more carefully, especially when I wasn't completely sure about it!

I'm deploying the fix @aryanas159 created as an immediate remedy for now, since this issue greatly impacts the mobile experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behaviors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants