Skip to content

Missing ending quotation mark to "Added to [collection]" toast #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pie999 opened this issue Feb 14, 2024 · 3 comments · Fixed by #3026
Closed

Missing ending quotation mark to "Added to [collection]" toast #3021

pie999 opened this issue Feb 14, 2024 · 3 comments · Fixed by #3026
Assignees
Labels

Comments

@pie999
Copy link

pie999 commented Feb 14, 2024

p5.js version

v1.9.0

What is your operating system?

Windows

Web browser and version

Firefox 122.0.1

Actual Behavior

The ending quotation mark is missing from the "Added to [collection]" toast.

dispatch(setToastText(`Added to "${collectionName}`));

Expected Behavior

There should be a quotation mark after ${collectionName}.

Steps to reproduce

Add a sketch to a collection.

@pie999 pie999 added the Bug label Feb 14, 2024
Copy link

welcome bot commented Feb 14, 2024

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@aditya3011ai
Copy link
Contributor

aditya3011ai commented Feb 14, 2024

Hi @pie999 , I would like to work on this Bug could you please assign it to me.

@lindapaiste
Copy link
Collaborator

This is definitely a mistake. But also, we really should migrate all three of those texts to our translation system. They are not getting translated at all right now.

dispatch(setToastText(`Created "${newCollection.name}"`));

dispatch(setToastText(`Added to "${collectionName}`));

dispatch(setToastText(`Removed from "${collectionName}`));

aditya3011ai added a commit to aditya3011ai/p5.js-web-editor that referenced this issue Feb 15, 2024
lindapaiste added a commit that referenced this issue Feb 19, 2024
Added Missing ending quotation mark to "Added to [collection]" toast #3021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants