-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Converting Editor/index.js into a functional component #3041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I want to work on this @Keshav-0907 can you assign me this error? |
I want to work on this issue. @Keshav-0907 can you assign me? Below is the preview of changes that can be made. |
If this issue is still relevant and important, I would like to work on it. Could you please assign it to me? @Keshav-0907 @raclim @lindapaiste |
Thanks for showing interest in this issue @Aseem22! I think we might hold off on this for now until the summer, which is when we're hoping to revisit this. |
@raclim I think this issue is related to upgrading CodeMirror to v6, as one of the |
@PiyushChandra17 Yes! As this issue is a part of that project, it ideally would be handled altogether by the fellow who would be working on it over the summer. However, feel free to suggest ideas or raise any concerns that you foresee with tackling this! |
@raclim Sure, that was very informative! I would try .. :) |
@raclim @PiyushChandra17, Is a candidate with around 8-9 months of experience in open source considered eligible or suitable for acceptance as a fellow? I would love to contribute in this project as a fellow. |
@Aseem22 Here is a full description of the fellowship and its eligibility requirements! The application portal will be open until May 31st. |
Thanks!! |
Increasing Access
Functional components are simpler, shorter, and more performant. Additionally, with the introduction of Hooks, they can effectively manage state and side effects
Feature enhancement details
We should convert the Editor/index.js class component to a functional component as it is recommended for improved simplicity, brevity, and performance.
p5.js-web-editor/client/modules/IDE/components/Editor/index.jsx
Lines 84 to 91 in 96c5470
The text was updated successfully, but these errors were encountered: