-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bulk Sketch Download Feature (Fixes #1939) #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Release EnvironmentsThis pull request environment is provided by Release, learn more! 🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-fc99ae525e |
Here's my fix for issue #1939. It's able to combine all projects into a single zip file but we're going to need to do a serious refactor the bundleExternalLibs() function in project.controller.js if we want to add external dependency files to each project. I'm also not sure about the placement of the "Download all" button on the sketches page. Thanks |
…mbining projects for export to zip.
Managed to add external lib bundling to bundled project files without doing any major refactoring after all. |
If there is anything I can do to help get this feature over the finish line, this is something I'd love to see. It is also similar to this PR about downloading collections as a zip: #1997 |
Hey @dwight9339, sorry for the delay in reviewing this! Would you be interested in revisiting this again? I'd love to see your work on this come to fruition in the near future! |
I'm going to close this for now, but please feel free to rework this PR or create a new one regarding this feature! |
Fixes #issue-number
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123