Skip to content

Bulk Sketch Download Feature (Fixes #1939) #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dwight9339
Copy link
Contributor

Fixes #issue-number

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Feb 3, 2022

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Feb 3, 2022

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-fc99ae525e

@dwight9339
Copy link
Contributor Author

Here's my fix for issue #1939. It's able to combine all projects into a single zip file but we're going to need to do a serious refactor the bundleExternalLibs() function in project.controller.js if we want to add external dependency files to each project. I'm also not sure about the placement of the "Download all" button on the sketches page. Thanks

@dwight9339
Copy link
Contributor Author

Managed to add external lib bundling to bundled project files without doing any major refactoring after all.

@dwight9339 dwight9339 marked this pull request as ready for review February 12, 2022 21:20
@NanoDano
Copy link

NanoDano commented Jul 3, 2022

If there is anything I can do to help get this feature over the finish line, this is something I'd love to see. It is also similar to this PR about downloading collections as a zip: #1997

@raclim
Copy link
Collaborator

raclim commented Jul 11, 2023

Hey @dwight9339, sorry for the delay in reviewing this!

Would you be interested in revisiting this again? I'd love to see your work on this come to fruition in the near future!

@raclim
Copy link
Collaborator

raclim commented Jul 17, 2023

I'm going to close this for now, but please feel free to rework this PR or create a new one regarding this feature!

@raclim raclim closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants