Skip to content

Fixes #2250 - Don't show loader after the collection has been loaded. #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2250

Changes:

  • Change the defaultProps for collection from an incomplete/fake object to null. This way it's easy to know when the collection has been loaded.
  • <Loader/> component won't be displayed after this.props.collection has been set, regardless of the value of this.props.loading.
  • hasCollection only looks to see if it has a valid collection prop and does not consider this.props.loading. Consequently the collection details will stay visible while the popup content is loading.
  • The empty table will be displayed whenever there is a collection but it has no items. Loading is not considered. The change in the defaultProps makes this check possible.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and working on this!

@raclim raclim merged commit 34cda50 into processing:develop Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Collection details disappears for a moment when clicking "Add Sketch"
2 participants