Fixes #2250 - Don't show loader after the collection has been loaded. #2252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2250
Changes:
defaultProps
forcollection
from an incomplete/fake object tonull
. This way it's easy to know when the collection has been loaded.<Loader/>
component won't be displayed afterthis.props.collection
has been set, regardless of the value ofthis.props.loading
.hasCollection
only looks to see if it has a valid collection prop and does not considerthis.props.loading
. Consequently the collection details will stay visible while the popup content is loading.defaultProps
makes this check possible.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123