Skip to content

Download collection as a zip #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mhsh312
Copy link
Contributor

@mhsh312 mhsh312 commented Dec 16, 2023

Fixes #273

Changes:

  • Added a Download Collection button in the Share dropdown of Collection
  • Added Download Collection in English translation file
  • Added a new controller downloadCollection

Logic: I created a controller that makes a database call for a collection ID and then created a function formatCollection that changes the JSON format of this collection such that it becomes compatible with the existing addFileToZip function. I also handled the library file bundling with a new function bundleExternalLibsForCollection which makes it so each project gets it's own library file bundled.

End result: a zip file with the name of the collection and collection owner and all the projects of the collection as subfolders where each subfolder includes library files of that specific project.

image

image

image

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Dec 27, 2023

Thanks for working on this, this is really awesome! Looking over it at a glance I think this looks good so far. We're currently on break, so I'll try to give it a more thorough review once we come back early January!

@mhsh312
Copy link
Contributor Author

mhsh312 commented Jan 20, 2024

Hey @raclim any updates on this?

@raclim
Copy link
Collaborator

raclim commented Jun 24, 2024

I'm really sorry that it took a while to get back to this! I might've noted this on one of the other PRs you've submitted, but due to some of the changes here falling out of date and some of the other features/fixes we'd like to prioritize over the next two months, I'm going to close this pull request for now.

I'm really sorry again that it took a while to get to this and that we couldn't get this in at the moment, but please feel free to update and reopen this pull request in the future!

@raclim raclim closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Collections as zip
2 participants