Skip to content

About page width updated #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

ABHIJITHDL
Copy link

Fixes #2700

Changes: Updated the About Block width to prevent content overflowing on changing language.
Before:
Screenshot (68)
After:
Screenshot (69)
I've tested this for all the languages.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #2700

Copy link

welcome bot commented Dec 23, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Jan 26, 2024

Thanks for submitting this! I think the solution we're looking for is closer to what's mentioned here, where we'd prefer to have the text within the column to wrap (#2700 (comment)). At a first glance this change might be okay, but I feel hesitant to have something in that changes the size of the whole modal. I'm going to close this for now, but please feel free to resubmit this or check out the other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Block content overflowing on changing language
2 participants