Partial Fixed: Mobile responsiveness of find and replace dialog box #2854
Conversation
| @@ -79,6 +79,7 @@ pre.CodeMirror-line { | |||
| } | |||
| // left: 0 !important; | |||
| width: #{48 / $base-font-size}rem; | |||
| z-index: 0; | |||
There was a problem hiding this comment.
We probably don't need an explicit z-index here.
It looks like there's a z-index: 4 on the .CodeMirror-gutter-wrapper div which is coming from the core CodeMirror library. I assume it's there for a reason so let's not mess with it.
| z-index: 5; | ||
| } | ||
|
|
||
| z-index: 1; |
There was a problem hiding this comment.
Let's change the existing z-index: 1 (line 101) to z-index: 5, regardless of breakpoint. Like it's not an issue on larger screens because the dialog doesn't overlap the gutter, but it does seem "right" that it should have a higher z-index.
|
|
||
| @media (max-width: 580px) { | ||
| padding: 0.6rem 0rem; | ||
| } |
There was a problem hiding this comment.
This seems unrelated to the z-index issues. So let's save that for a PR where we fix the layout.
There was a problem hiding this comment.
OK, I will raise a new pr for it. Thank you
|
I'm sorry but I forgot about this PR! I'm going to close it because the |
Partial Fixes #2839
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123