Typescript Migration: client/modules/IDE/hook and client/modules/IDE/utils#3787
Open
clairep94 wants to merge 24 commits intoprocessing:developfrom
Open
Typescript Migration: client/modules/IDE/hook and client/modules/IDE/utils#3787clairep94 wants to merge 24 commits intoprocessing:developfrom
client/modules/IDE/hook and client/modules/IDE/utils#3787clairep94 wants to merge 24 commits intoprocessing:developfrom
Conversation
clairep94
commented
Jan 10, 2026
Collaborator
Author
There was a problem hiding this comment.
memoized the methods in useSketchActions
clairep94
changed the title
client/modules/IDE/hook and client/modules/IDE/utils
clairep94
added
the
Area: Typescript Migration
raclim
reviewed
Jan 27, 2026
| } from '../../../../test-utils'; | ||
| import { selectProjectName } from '../../selectors/project'; | ||
| import ToolbarComponent from './Toolbar'; | ||
| import { P5VersionProvider } from '../../hooks/useP5Version'; |
Collaborator
There was a problem hiding this comment.
Thanks so much for catching this!
raclim
reviewed
Jan 27, 2026
| autosaveProject, | ||
| user, | ||
| project, | ||
| autosaveProject, |
Collaborator
There was a problem hiding this comment.
I think autosaveProject might be a duplicate!
raclim
reviewed
Jan 27, 2026
| }, [dispatch, showToast, newProject, unsavedChanges]); | ||
|
|
||
| const saveSketch = useCallback( | ||
| (cmController: { getContent: () => null | undefined }) => { |
Collaborator
There was a problem hiding this comment.
Just want to confirm if the typing null | undefined is correct here!
Collaborator
|
Thanks so much for the cleanup!!! I just had a few comments in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
client/modules/IDE/hooksandclient/modules/IDE/utilsChanges:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123