Skip to content

Teach Page Rebasing #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 421 commits into from
Jul 27, 2022
Merged

Teach Page Rebasing #1245

merged 421 commits into from
Jul 27, 2022

Conversation

Gracia-zhang
Copy link
Contributor

Fixes #[Add issue number here]

Changes:
upstream: main --> origin: teach

Screenshots of the change:

camilleroux and others added 30 commits October 8, 2021 22:49
Get Started page: remove errant comma
…d_link

removed link that is no longer in use
…s_to_object_category

Moved car instances into the Object category
Add 2021 fundraiser link to the banner
Get Started page: Remove Extra the
update Chinese translation of 'Donate' and 'Teach' at the sidebar
Change line endings to Unix style for copy() method example
Also optimized template for better i18n.
Qianqianye and others added 19 commits July 14, 2022 22:47
…vek-hindi-trans

Hindi Translation for line 846-848 Added
Updated link of JAVA install.
Reiterate the instruction for clonning repo.
docs: fixed java link and cloning instruction
Some text is edited following reviewer's suggestion and comments,
There is not-edited text yet, I will translate it after making appropriate conclusion.
Edit p5.bezier translation
…NG]toKOR]

Snp0301 translation [ENG] to [KOR]
@Qianqianye Qianqianye requested a review from yinhwa July 23, 2022 04:56
Copy link
Contributor

@3ru 3ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Gracia-zhang, I have seen your past PRs.

Am I correct here that you want to match the teach branch to the latest main?
What you are doing is correct, but in the end, you need to resolve conflicts between branches.
conflict

You can see what exactly is in conflict here.
image

Conflict resolution is simply the process of deciding whether to prioritize current or past commitments.
As far as I can ascertain, the conflicts this time are for 2020-2021 commits (8b55a32, 899b132, etc.) and it is better to ask @yinhwa for help.

Also, regarding the PR outline, it would be great if you could include a description of why you want to do it and how the PR will solve the problem. This will help us in the present, but also for someone in the future😸.

I'm not confident that what is described is completely correct, and there are several ways to resolve conflicts, so I would appreciate it if you could look into this on your own:pray:

@yinhwa
Copy link
Contributor

yinhwa commented Jul 24, 2022

Hi @3ru thank you so much for the kindly instruction for Gracia :) I really appreciate it. We'll discuss on the conflicts soon and get the rebasing done!

@Gracia-zhang
Copy link
Contributor Author

Thanks @3ru for your detailed guide! I'll discuss with @yinhwa and I think we'll figure it out soon!

@Gracia-zhang Gracia-zhang changed the title Teach Rebase Teach Page Rebasing Jul 24, 2022
Copy link
Contributor

@yinhwa yinhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gracia-zhang for this commit :) Just one thing you might wanna change:

in src/data/es.yml file, could we keep the Spanish version of the codes, as this file is dedicated for Spanish translation. You can simply change lines 1707-1715 into the original Spanish version.

I guess we are good to merge, once you make this final change :)

Revert the Spanish version of line 1707-1715
@Gracia-zhang
Copy link
Contributor Author

Hi @yinhwa , I reverted the Spanish version of es.yml file on line 1707-1715 with GitHub editor. I think we are good to merge!

@yinhwa yinhwa merged commit 672669b into processing:teach Jul 27, 2022
@yinhwa
Copy link
Contributor

yinhwa commented Jul 27, 2022

Think you can reopen the post updates PR now @Gracia-zhang yay~💙💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.