Optimized 2D Primitives Test Suite: Bug Fixes and Validation Improvements #6693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In 'p5.prototype.ellipse', fixed missing param #2 and #3 issues. 2. In 'p5.prototype.rect', handled missing param #5 to throw validation error. 3. Updated 'p5.prototype.square' to handle missing param #3 appropriately. 4. Fixed a bug in 'p5.prototype.line' where incorrect parameters did not trigger validation errors. 5. Improved error messaging in 'p5.prototype.triangle' for better clarity.
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
It looks like this PR has added a lot of files, are those intentional? Do you mind looking through the diff of this PR and cleaning up the code to make sure only the changes you want are present in the diff? |
|
@davepagurek ahh i think this bcs .history files alot added let me correct it |
|
can u look now ? |
|
There are still changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6686
Changes:
p5.prototype.ellipse: Fixed missing parameters JS Desktop apps #2 and two.js #3, resolving validation issues.
p5.prototype.rect: Handled missing parameter node.js & Java #5 to properly throw validation errors.
p5.prototype.square: Updated to handle missing parameter two.js #3 appropriately.
p5.prototype.line: Fixed a bug where incorrect parameters did not trigger validation errors.
p5.prototype.triangle: Improved error messaging for better clarity.
PR Checklist:
npm run lintpasses