Skip to content

Refactoring book:build #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bagasme opened this issue Jan 24, 2021 · 5 comments · Fixed by #1598
Closed

Refactoring book:build #1595

bagasme opened this issue Jan 24, 2021 · 5 comments · Fixed by #1598

Comments

@bagasme
Copy link
Contributor

bagasme commented Jan 24, 2021

I'm proposing to refactor book:build task on Rakefile.

The task will be split into:

  1. generating book/contributors.txt (as prerequisites)
  2. one build task for each supported formats (html, epub, and pdf)

Also introduce book:clean task, which will remove all generated artifacts (book/contributors.txt, progit.{html,epub,pdf})

@jnavila
Copy link
Member

jnavila commented Jan 25, 2021

While you are at it, I would also like to split the tasks of checking some artifacts (html, epub), from the task of building all of them (pdf). PDF takes a lot of time and does not check anything, so it is useless for CI.

@bagasme
Copy link
Contributor Author

bagasme commented Jan 25, 2021

@jnavila ok, but should book:build still check artifacts (html and epub, minus pdf), right?

@jnavila
Copy link
Member

jnavila commented Jan 25, 2021

We could have a target book:ci which only builds for checking and book:build which only focuses on artifacts. The check could be performed for book:build but errors would not lead to failure.

@bagasme
Copy link
Contributor Author

bagasme commented Jan 26, 2021

@jnavila did you mean book:ci only for checking the generated books? And should book:ci be default task for CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@jnavila @bagasme and others