Update asciidoctor requirement from 1.5.6.2 to 2.0.10 #1355
Conversation
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
Updates the requirements on [asciidoctor](https://github.com/asciidoctor/asciidoctor) to permit the latest version. - [Release notes](https://github.com/asciidoctor/asciidoctor/releases) - [Changelog](https://github.com/asciidoctor/asciidoctor/blob/master/CHANGELOG.adoc) - [Commits](asciidoctor/asciidoctor@v1.5.6.2...v2.0.10) Signed-off-by: dependabot-preview[bot] <[email protected]>
dependabot-preview
bot
added
the
dependencies
|
It's alive! 👻 Though we shouldn't yet merge it (#1354):
|
|
It isn't clear what problem #1354 talks about. It is asciidoctor/asciidoctor-epub3#210? If yes, that bug was fixed in (already released) asciidoctor-epub3 1.5.0.alpha.10. |
|
Not only this, we have to apply the whole migration cheatsheet to the book. |
|
@jnavila Do you want help with the migration? I'm assuming we would migrate from the Legacy to the Modern syntax, as listed in the cheatsheet? |
|
@HonkingGoose I'm working a script that could also be applied to all translations. I'll push the result in a dedicated branch for PR and let you know for review. |
|
Ah okay, I was thinking I could help go over it by changing it manually. But a script might be a lot faster. :) I'll look over it then when it's ready. |
|
@jnavila could you share your script? |
|
Add this task to the Rakefile file desc 'convert book for asciidoctor 2.x'
task:migrate_asciidoctor2 do
root_files = Dir['ch*.asc'] + Dir['[ABC]*.asc'] + Dir[File.join ["book", "*.asc"]]
files = Dir[File.join ["book","*" , "sections","*.asc"]]+
root_files
files.each { |filename|
content = File.read(filename)
content.gsub!(/`(\*|a\/\*\*\/z)`|`(http|file:)|`\*\.c/,
'`*`' => "`+*+`",
'`a/**/z`' => "`+a/**/z+`",
'`http' => "`\\http",
'`file:' => "`\\file:",
'`*.c' => "`+++*.c+++")
content.gsub!(/``(.*?)''/, '"`\1`"')
File.open(filename, "w") {|file| file.puts content }
}
content = File.read('progit.asc')
content.gsub!('.asc', '.adoc')
File.open('progit.asc', 'w') { |file| file.puts content }
root_files.each { |filename|
new_name = filename.gsub('.asc', '.adoc')
`git mv #{filename} #{new_name}`
}
`git mv index.asc index.adoc`
endThis PR is not based on the script and was manually edited. But, diffing with the result of the script, I'd rather use the result from this task. |
|
I think that |
|
@Morganov If I change the version in progit/progit2-pub, all the translated repos using these script must be translated to be compatible with asciidoctor v2.0.10. Right now the CJK (Chinese, Japanese, Korean) extensions of asciidoctor are incompatible with v2.0.10 |
|
This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on asciidoctor to permit the latest version.
Release notes
Sourced from asciidoctor's releases.
Changelog
Sourced from asciidoctor's changelog.
Commits
9302213Release 2.0.10eb685d9add missing entry for #3110 to CHANGELOG [skip ci]8f83870resolves #3316 fix Asciidoctor.convert_file to honor header_footer: false opt...66ae48dSynchronize Japanese README with English version (PR #3301)e1beaa9add missing entry to CHANGELOG for #3308 [skip ci]c28ad27refine emdash replacement2acdcecresolves #3308 honor image value for icons attribute1956a18resolves #3300 fix signature of SyntaxHighlighter#docinfo method (PR #3303)e272e40always pass same options to SyntaxHighlighter#docinfo methodae6440cadd missing changelog entry for #3289 [skip ci]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump nowin your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: