Skip to content

Temp fix for breaking builds: drop kindlegen dependency, drop .mobi build #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Temp fix for breaking builds: drop kindlegen dependency, drop .mobi build #1497

merged 1 commit into from
Aug 28, 2020

Conversation

HonkingGoose
Copy link
Contributor

@HonkingGoose HonkingGoose commented Aug 25, 2020

Changes

  • Drop kindlegen dependency from Gemfile
  • Comment out the .mobi builds, and add explanation about why the .mobi build is dropped.

Context

We currently have failing builds because the kindlegen dependency is no longer available for download for Travis CI (or locally for that matter). This is a quick-fix to get our builds working again.

⚠️ Merging this pull request will mean that readers will not get a .mobi file when we release new builds. ⚠️
The alternative is having no build/release at all until the problem is fully resolved upstream.

For more on this see #1496.


EDIT:
There's also a quick-fix band-aid "solution", that I only mention for completeness sake.
Quote from tdtds/kindlegen#42 (comment):

If you've already installed the kindlegem gem, you can salvage the kindlegen tar.gz file from under the ext directory of the extracted gem file. You can use that to make the kindlegen gem rebuildable, but that's as far as you can go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants