Skip to content

Fix 2 outstanding review issues for Asciidoctor 2 migration #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix 2 outstanding review issues for Asciidoctor 2 migration #1541

wants to merge 2 commits into from

Conversation

HonkingGoose
Copy link
Contributor

Changes

  • Undo rake script on Markdown file
  • Undo rake script on Ruby file

Context

Hi @jnavila, I'm fixing 2 issues I raised in this review: #1373 (review)

@HonkingGoose HonkingGoose mentioned this pull request Oct 11, 2020
Closed
@HonkingGoose HonkingGoose mentioned this pull request Nov 3, 2020
Merged
2 tasks
@jnavila jnavila closed this in #1554 Nov 6, 2020
@HonkingGoose HonkingGoose deleted the fork_asciidoctor_2.0.10 branch November 6, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HonkingGoose