-
Notifications
You must be signed in to change notification settings - Fork 2k
Enable .mobi (Kindle) format again #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward. Thank you!
In fact, the mobi file is missing in the cleaning task! |
@jnavila can you point me to what went wrong? EDIT: I found the code you're mentioning: Lines 109 to 125 in 5eb9b0c
You're right it's missing here! |
I think the refactoring PR #1598 made some more changes, so that just inserting the old code is no longer working properly.... |
Changes
.mobi
(Kindle) format againContext
Fixes #1528
asciidoctor-epub3
has the Kindlegen dependency in it again, so we can enable mobi builds again. (#1646 (comment))Please check if this change alone is enough to get things working.
@slonopotamus @jnavila can you please check my work?