Skip to content

Enable .mobi (Kindle) format again #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Enable .mobi (Kindle) format again #1655

merged 2 commits into from
Jun 15, 2021

Conversation

HonkingGoose
Copy link
Contributor

@HonkingGoose HonkingGoose commented Jun 15, 2021

Changes

  • Enable .mobi (Kindle) format again
  • Add references to mobi files back in README
  • Add mobi rake build command to README

Context

Fixes #1528

asciidoctor-epub3 has the Kindlegen dependency in it again, so we can enable mobi builds again. (#1646 (comment))

Please check if this change alone is enough to get things working.

@slonopotamus @jnavila can you please check my work?

@slonopotamus
Copy link
Contributor

Looks OK

Copy link
Member

@jnavila jnavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward. Thank you!

@jnavila jnavila merged commit 5eb9b0c into progit:master Jun 15, 2021
@jnavila
Copy link
Member

jnavila commented Jun 15, 2021

In fact, the mobi file is missing in the cleaning task!

@HonkingGoose
Copy link
Contributor Author

HonkingGoose commented Jun 15, 2021

@jnavila can you point me to what went wrong?

EDIT: I found the code you're mentioning:

progit2/Rakefile

Lines 109 to 125 in 5eb9b0c

desc 'Clean all generated files'
task :clean do
begin
puts 'Removing generated files'
FileList['book/contributors.txt', 'progit.html', 'progit.epub', 'progit.pdf'].each do |file|
rm file
# Rescue if file not found
rescue Errno::ENOENT => e
begin
puts e.message
puts 'Error removing files (ignored)'
end
end
end
end

You're right it's missing here!

@HonkingGoose HonkingGoose deleted the patch-2 branch June 15, 2021 20:04
@HonkingGoose
Copy link
Contributor Author

HonkingGoose commented Jun 15, 2021

I think the refactoring PR #1598 made some more changes, so that just inserting the old code is no longer working properly....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: does the ProGit2 project want to keep providing Kindle files?
3 participants