Skip to content

Add recommendation note #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2016
Merged

Add recommendation note #555

merged 2 commits into from
Mar 15, 2016

Conversation

nemoinho
Copy link

@nemoinho nemoinho commented Mar 9, 2016

#550 Add note that it is not recommended to use --no-metadata because it may breaks

synchronisation between git and svn.

Add note that it is not recommended to use --no-metadata because it may breaks
synchronisation between git and svn.
@ben
Copy link
Member

ben commented Mar 14, 2016

Hmm. Ordinarily I'd say this is good, but since this section is about doing a one-way conversion to Git, we may not actually want the metadata in the commit messages. Can we reword the warning to be something more like this?

You can also tell git svn not to include the metadata that Subversion normally imports, by passing --no-metadata to the clone or init command (though if you want to keep the metadata, feel free to omit this parameter).

Updated the note due to the argumentation of
#555 (comment)

So the comment is less radical and fits better into the context of a
migration from svn to git.
@nemoinho
Copy link
Author

Yes, this is also ok, but let me add one more word to your suggestion:

You can also tell git svn not to include the metadata that Subversion normally imports, by passing --no-metadata to the clone or init command (though if you want to keep the synchronisation-metadata, feel free to omit this parameter).

So I changed the pull-request like that.

@ben
Copy link
Member

ben commented Mar 15, 2016

Nice. Thanks!

ben added a commit that referenced this pull request Mar 15, 2016
@ben ben merged commit ace799b into progit:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants