Skip to content

Automatically infer PodSets for well-known kinds #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgrove-oss opened this issue Mar 26, 2024 · 2 comments
Closed

Automatically infer PodSets for well-known kinds #65

dgrove-oss opened this issue Mar 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dgrove-oss
Copy link
Collaborator

We can make the specification of a PodSet for Component optional for common cases when we can recognize the GVK of the component. This would lower the barrier to entry for using AppWrappers.

Some low hanging fruit with PodSpecTemplates: Jobs, Deployments, StatefulSets, PyTorchJob, RayJobs/Clusters, JobSets.

We probably should do this in conjunction with an extension to the validating web hook that rejects an AppWrapper that contains any unknown GVKs that don't have explicit PodSets and appear to contain PodSpecTemplates within them. A stricter alternative would be to also recognize common GVKs that don't create pods (Secrets, ConfigMaps, ServiceAccount, etc) and reject any unknown GVK that doesn't have an explicit PodSet (which may say 0 replicas for resources that don't create Pods).

@dgrove-oss dgrove-oss added the enhancement New feature or request label Mar 26, 2024
@tardieu
Copy link
Member

tardieu commented Apr 26, 2024

The initial implementation was merged in #108. Keeping this issue open for now until we decide whether to support a mode where unknowns GVKs are rejected.

@dgrove-oss
Copy link
Collaborator Author

Going to close this and open a new issue for the strict mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants