Skip to content

Infer pod sets for known GVKs #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Infer pod sets for known GVKs #108

merged 4 commits into from
Apr 25, 2024

Conversation

tardieu
Copy link
Member

@tardieu tardieu commented Apr 22, 2024

This PR extends the defaulting webhook to infer pod sets for components such as pods and deployments when not explicitly specified.

@tardieu tardieu requested a review from dgrove-oss April 24, 2024 17:28
@tardieu tardieu added the enhancement New feature or request label Apr 24, 2024
@tardieu tardieu marked this pull request as ready for review April 24, 2024 17:31
@dgrove-oss dgrove-oss changed the title Infer pod sets for know GVKs Infer pod sets for known GVKs Apr 24, 2024
Copy link
Collaborator

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tardieu tardieu merged commit b87fa22 into main Apr 25, 2024
@tardieu tardieu deleted the inference branch April 25, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants