Skip to content

[e2e] Add Host to Container port mapping for KinD Cluster #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

Related to: https://issues.redhat.com/browse/RHOAIENG-2058

What changes have been made

  • Map Host Port 80 to Container Port 80 in KinD Setup. Required for usage against CodeFlare-SDK e2e test.
  • Renamed directory.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Jan 31, 2024
@sutaakar
Copy link
Contributor

@ChristianZaccaria Can you remove the merge commit but rather rebase your change?

@ChristianZaccaria
Copy link
Contributor Author

@ChristianZaccaria Can you remove the merge commit but rather rebase your change?

Sure thing - Removed and rebased, thanks Karel

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 31, 2024
Copy link

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4d01c30 into project-codeflare:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants