Skip to content

Update CodeFlare stack release instructions #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anishasthana
Copy link
Contributor

No description provided.

@anishasthana
Copy link
Contributor Author

@sutaakar Raising this PR, I was thinking... Maybe we should update the release action to allow users to select which components are going to have releases. This would lessen the burden on users (as opposed to forcing them to manually go to each repo and run the corresponding action)

@sutaakar
Copy link
Contributor

/lgtm

@sutaakar
Copy link
Contributor

@anishasthana It can be done, though it will need some adjustments in workflows.
Just to be sure, the release strategy remains the same, right? By default release all components, occasionally for hotfix release just subset of components.

@anishasthana
Copy link
Contributor Author

Just to be sure, the release strategy remains the same, right? By default release all components, occasionally for hotfix release just subset of components.

Yep! That's where my head is at. Something like a checkbox would probably suffice

Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8d4c413 into project-codeflare:main Aug 11, 2023
@anishasthana anishasthana deleted the add_release_process branch August 12, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants