Skip to content

Updating make manifests target #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2023
Merged

Updating make manifests target #363

merged 2 commits into from
Oct 24, 2023

Conversation

Fiona-Waters
Copy link
Contributor

@Fiona-Waters Fiona-Waters commented Oct 22, 2023 •
edited
Loading

Issue link

Closes #364

What changes have been made

  • Update to manifests make target allowing for division of crd files using yq.
  • Addition of install-yq make target.
  • Update to crd/kustomization.yaml to include separate crds.
  • Update to mcad/kustomizaton.yaml with latest version.
  • Adding created CRD files.

Verification steps

  • Checkout this PR
  • Run make manifests and ensure that it works as expected

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Fiona-Waters Fiona-Waters mentioned this pull request Oct 23, 2023
Closed
@Fiona-Waters Fiona-Waters force-pushed the makefile-crds branch 3 times, most recently from 687cb6f to 9633914 Compare October 24, 2023 08:42
@Fiona-Waters Fiona-Waters marked this pull request as ready for review October 24, 2023 09:39
@openshift-ci openshift-ci bot requested review from astefanutti and jbusche October 24, 2023 09:39
@Fiona-Waters Fiona-Waters changed the title [WIP] Updating make manifests target Updating make manifests target Oct 24, 2023
astefanutti
astefanutti reviewed Oct 24, 2023
View reviewed changes
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 24, 2023
@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b051b1a into project-codeflare:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti left review comments

@jbusche jbusche Awaiting requested review from jbusche

Assignees

@astefanutti astefanutti

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update make manifests target
2 participants
@Fiona-Waters @astefanutti