Skip to content

is_dashboard_ready error causes wait_ready to crash #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChristianZaccaria opened this issue Sep 25, 2023 · 0 comments · Fixed by #356
Closed

is_dashboard_ready error causes wait_ready to crash #355

ChristianZaccaria opened this issue Sep 25, 2023 · 0 comments · Fixed by #356
Assignees
@ChristianZaccaria

Comments

@ChristianZaccaria
Copy link
Collaborator

Describe the Bug

Based on this Slack thread by @Maxusmusti

The is_dashboard_ready check errors out when the cluster/appwrapper is still in a pending state, causing wait_ready to crash.

Steps to Reproduce the Bug

  1. Run cluster.up() and cluster.wait_ready() together.
  2. See the error.

Potential solution

Checking if the dashboard is ready AFTER the cluster is ready, instead of both at every timestep from the start.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianZaccaria ChristianZaccaria

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for dashboard readiness after cluster is ready ChristianZaccaria/codeflare-sdk
1 participant
@ChristianZaccaria