-
Notifications
You must be signed in to change notification settings - Fork 54
Check for dashboard readiness after cluster is ready #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for dashboard readiness after cluster is ready #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one request that I know may be worth adding for the future
Also, looks like pre-commit test failed, may need to run. |
1a5c80f
to
1862182
Compare
1862182
to
758a891
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Maxusmusti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Resolves #355
What changes have been made
The check for
is_dashboard_ready
is now performed after the cluster is ready.Verification steps
cluster.up()
andcluster.wait_ready()
together.Checks