RHOAIENG-50554: Make kueue optional for RayJob#1013
RHOAIENG-50554: Make kueue optional for RayJob#1013kryanbeane wants to merge 1 commit intoproject-codeflare:mainfrom
Conversation
|
@kryanbeane: This pull request references RHOAIENG-50554 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
- Coverage 95.97% 95.96% -0.01%
==========================================
Files 23 23
Lines 2211 2208 -3
==========================================
- Hits 2122 2119 -3
Misses 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue link
https://issues.redhat.com/browse/RHOAIENG-50554
What changes have been made
Make Kueue optional for RayJob, matching existing RayCluster behavior.
Previously, RayJob always injected a Kueue queue label (falling back to
"default") and setsuspend: true, causing jobs to hang when Kueue was not installed or no LocalQueue existed. Now:local_queueis omitted and no default LocalQueue is found, no Kueue label is added and the job runs without Kueuelocal_queueis provided or a default is auto-detected, the label is setsuspend: true— Kueue's mutating admission webhook handles suspension automatically when installedVerification steps
local_queue="your-queue"— verify the queue label is set and the job completeslocal_queuein a namespace with a default LocalQueue — verify the default queue is auto-detected and the job completeslocal_queueon a cluster where Kueue is not installed or no LocalQueue exists — verify no Kueue label is added and the job runs immediately without hangingChecks