Skip to content

Downgrade pydantic to prevent breaking introduced by pydantic 2 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

Downgrade pydantic to prevent breaking introduced by pydantic 2 #215

merged 1 commit into from
Jul 12, 2023

Conversation

tedhtchang
Copy link
Member

@tedhtchang tedhtchang commented Jul 10, 2023 •
edited
Loading

Downgrad pydantic package to prevent breaking from doing pip install -r requirements.txt
Fixes #214
How to test:

# clone the branch
git clone --single-branch --branch limit-pydantic-version  https://github.com/tedhtchang/codeflare-sdk.git
cd codeflare-sdk/

# create new python virtual env with [pyenv](https://github.com/pyenv/pyenv#automatic-installer)
pyenv install 3.8.13
pyenv virtualenv 3.8.13 limit-pydantic-version
pyenv local limit-pydantic-version
pip install -r requirements.txt

verify pydantic < 2.0.*
image

@tedhtchang tedhtchang changed the title downgrad pydantic package to prevent breaking introduced by pydantic 2 Downgrad pydantic package to prevent breaking introduced by pydantic 2 Jul 10, 2023
@tedhtchang tedhtchang changed the title Downgrad pydantic package to prevent breaking introduced by pydantic 2 Downgrade pydantic to prevent breaking introduced by pydantic 2 Jul 10, 2023
Bobbins228
Bobbins228 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can verify on testing this I installed pydantic<2 nice work Ted

@tedhtchang tedhtchang mentioned this pull request Jul 12, 2023
Closed
@MichaelClifford MichaelClifford merged commit 0d9b23c into project-codeflare:main Jul 12, 2023
vaibssingh pushed a commit to vaibssingh/codeflare-sdk that referenced this pull request Jul 13, 2023
@tedhtchang @vaibssingh
downgrad pydantic package to prevent breaking from doing pip install …
b5e2e75 
…-r requirements.txt (project-codeflare#215)
@tedhtchang tedhtchang mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelClifford MichaelClifford MichaelClifford approved these changes

@Bobbins228 Bobbins228 Bobbins228 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ray package has a breaking dependency pydantic>2.0.*
3 participants
@tedhtchang @MichaelClifford @Bobbins228