Fixed ingress domain methods #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran verification steps and can confirm that it works as expected. |
Fiona-Waters
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Added the
api_config_handler()method toclient.CustomObjectsApimethods so that when a user authenticates with their token and password it uses their api instance.Verification steps
poetry buildin the codeflare folder from the terminalpip install dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whllocal_interactive = Truecluster.up()cluster.local_client_url()You should receive a url similar to this...
ray://rayclient-<"cluster-name">-<"namespace">.<"domain">Checks