Skip to content

Replaced load_kube_config() with config_check() #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2023
Merged

Replaced load_kube_config() with config_check() #351

merged 1 commit into from
Sep 18, 2023

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Sep 15, 2023 •
edited
Loading

Issue link

Closes #336

What changes have been made

Replaced mentions of config.load_kube_config() with config_check() in cluster.py and generate_yaml.py

Verification steps

  • Make a copy of your ~/.kube/config file and delete the original
  • Run through the local_interactive Jupytr Notebook
  • Authenticate with your token + server
  • You should be able to run through the entire notbook without errors
  • The get_cluster() function should also work without errors this way

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

dimakis
dimakis approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked throught the code and verified it in cluster. Works as expected.
great work
LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimakis, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit abec0ef into project-codeflare:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice approved these changes

@dimakis dimakis dimakis approved these changes

@Fiona-Waters Fiona-Waters Awaiting requested review from Fiona-Waters

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

Assignees

@KPostOffice KPostOffice

@dimakis dimakis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace load_kube_config() with config_check()
4 participants
@Bobbins228 @KPostOffice @dimakis @openshift-merge-robot