Skip to content

Documented ingress functionality #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

Documented ingress functionality #416

merged 1 commit into from
Dec 5, 2023

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Nov 30, 2023 •
edited
Loading

Issue link

Closes #399

What changes have been made

Added documentation detailing the use of the ingress_domain and ingress_options config variables.

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

ChristianZaccaria
ChristianZaccaria requested changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @sutaakar this might be of interest, do we need more details on this documentation?

@sutaakar
Copy link
Contributor

It is fine for me.

@ChristianZaccaria
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
KPostOffice
KPostOffice approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include this in the actual code as well as descriptions for other config options. This /lgtm though, I will open another issue for documenting options in the source code, no need to make any changes here.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit b42d8e6 into project-codeflare:main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice approved these changes

@anishasthana anishasthana Awaiting requested review from anishasthana

@ChristianZaccaria ChristianZaccaria Awaiting requested review from ChristianZaccaria

Assignees

@KPostOffice KPostOffice

@ChristianZaccaria ChristianZaccaria

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write up documentation the new ingress functionality
4 participants
@Bobbins228 @sutaakar @ChristianZaccaria @KPostOffice