-
Notifications
You must be signed in to change notification settings - Fork 54
Add RayCLuster SDK Oauth Authentication test #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RayCLuster SDK Oauth Authentication test #449
Conversation
eefec6f
to
d494d2e
Compare
6f60dfc
to
4123677
Compare
Will convert this test to python tests similar to PR #451 |
95c4dc3
to
361a9ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through these changes with poetry run pytest -v -s ./tests/e2e/mnist_raycluster_sdk_oauth_test.py -m openshift
and I received this error.
tests/e2e/mnist_raycluster_sdk_oauth_test.py:65: in run_mnist_raycluster_sdk_oauth
self.assert_jobsubmit_withlogin(cluster)
tests/e2e/mnist_raycluster_sdk_oauth_test.py:105: in assert_jobsubmit_withlogin
status = job.status()
../.local/lib/python3.11/site-packages/codeflare_sdk/job/jobs.py:201: in status
return self._runner.status(self._app_handle)
../.local/lib/python3.11/site-packages/torchx/runner/api.py:419: in status
desc = scheduler.describe(app_id)
../.local/lib/python3.11/site-packages/torchx/schedulers/ray_scheduler.py:383: in describe
job_status_info = self._get_job_status(app_id)
../.local/lib/python3.11/site-packages/torchx/schedulers/ray_scheduler.py:376: in _get_job_status
client = self._get_ray_client(job_submission_netloc=addr)
With the final pytest error being:
FAILED tests/e2e/mnist_raycluster_sdk_oauth_test.py::TestRayClusterSDKOauth::test_mnist_ray_cluster_sdk_auth - ValueError: client netloc (ray-dashboard-mnist-test-ns-6t2pj.apps.rosa.mcampbel.n399.p3.openshiftapps.com) does not match job netloc (ray)
Did you come across something like this when testing @Srihari1192
@Bobbins228 no it works fine on my cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nitpick there. After that, lgtm
b2c34ff
to
34567dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to just need a rebase, afterwards, /lgtm
34567dc
to
3785a49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Srihari1192 Can you adjust https://github.com/project-codeflare/codeflare-sdk/blob/main/.github/workflows/e2e_tests.yaml#L126 to run all tests with proper |
Can you add timeout for tests? |
3785a49
to
190e0da
Compare
0c912e9
to
b4a1af4
Compare
b4a1af4
to
067b3d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff Srihari works like a charm 🥇
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, ChristianZaccaria, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
closes https://issues.redhat.com/browse/RHOAIENG-55
What changes have been made
Verification steps
Checks