ipywidgets UI create delete

[Bobbins228]

Issue link

Closes: RHOAIENG-12523

What changes have been made

• Added ipywidgets to act as buttons for the cluster.up() and cluster.down() methods
• Added print statements to confirm cluster creation/deletion
• Added unit tests for buttons
• Added wait_ready Check Box

Happy days :)

Verification steps

Setup

Notebook server ODH/RHOAI/Local

• Clone this repository with git clone https://github.com/project-codeflare/codeflare-sdk.git
• Checkout this PR's branch
• Run poetry build - install if needed (pip install poetry)
• Run pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whl
• Restart your notebook kernel

Testing

• Run through any example notebook
• On the ClusterConfiguration step the ui buttons for cluster up/down should appear
• Verify the buttons work as expected
• Run the ClusterConfiguration as a script and the buttons should not appear.
• Run in a RHOAI notebook and in a VSCode local notebook and verify buttons are created

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[KPostOffice]

Looks great, I've left a couple of comments

[ChristianZaccaria]

Great work! Just one small nitpick

[ChristianZaccaria]

Should we think of moving UI related items into their own file? - And keep strictly functionality in the cluster.py file?

[Bobbins228]

@ChristianZaccaria I had a similar thought when reading through the design doc.
I think we should go for it as to not clog the cluster.py file with the widgets.

[Bobbins228]

@ChristianZaccaria On second thought that may not be the best for this particular widget.
It requires the Cluster Object for the up() and down() methods so it is seemingly the only widget that should live in cluster.py.

[ChristianZaccaria]

@Bobbins228 perhaps the UI itself (only the buttons for example) can be separated into its own file, and the functionality (up() and down()) remain in the cluster.py file.

[KPostOffice]

One change, other than that I think it's g2g

[KPostOffice]

Just tested this all out and it works great! I have the smallest change ever then ready for merge I think

[KPostOffice]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KPostOffice]

/retest

Out of date

[Fiona-Waters]

/lgtm