Skip to content

make local_queue optional #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chipspeak
Copy link
Contributor

@chipspeak chipspeak commented May 27, 2025

Issue link

Jira Link

What changes have been made

Removed local_queue as a mandatory requirement ahead of larger Kueue changes.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fiona-waters for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.81%. Comparing base (028d0d5) to head (7a97551).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/codeflare_sdk/common/kueue/kueue.py 75.00% 2 Missing ⚠️
src/codeflare_sdk/ray/cluster/build_ray_cluster.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
+ Coverage   92.45%   92.81%   +0.35%     
==========================================
  Files          24       24              
  Lines        1419     1433      +14     
==========================================
+ Hits         1312     1330      +18     
+ Misses        107      103       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Pat O'Connor <[email protected]>
@chipspeak chipspeak closed this Jun 4, 2025
@chipspeak
Copy link
Contributor Author

reworked in a different PR here here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants