Skip to content

Release workflow opens PR with changes #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Aug 22, 2023

Issue link

closes #117

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from anishasthana and asm582 August 22, 2023 13:04
@Srihari1192 Srihari1192 requested a review from sutaakar August 22, 2023 13:05
@Srihari1192 Srihari1192 marked this pull request as draft August 22, 2023 13:06
@Srihari1192 Srihari1192 marked this pull request as ready for review August 22, 2023 13:19
@Srihari1192
Copy link
Contributor Author

Tested this changes for the steps Pull request creation and deletion here by manually approving PR as in fork
openshift-ci bot not available https://github.com/Srihari1192/instascale/actions/runs/5939307730/job/16105442608

@sutaakar
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 26ae232 into project-codeflare:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow should open a PR with changes instead of direct push
4 participants