mem optimization #277
mem optimization #277
Conversation
| @@ -310,6 +310,9 @@ func (gr *GenericResources) SyncQueueJob(aw *arbv1.AppWrapper, awr *arbv1.AppWra | |||
| } | |||
| } | |||
| } | |||
| //force nil so that Go can GC | |||
| unstruct.Object = nil | |||
There was a problem hiding this comment.
Not sure I understand this logic? Can you provide more context?
| //force nil so that Go can GC | ||
| m = nil | ||
| spec = nil | ||
| template = nil | ||
| marshal = nil |
There was a problem hiding this comment.
Not sure I understand this logic? Can you provide more context?
There was a problem hiding this comment.
Aren't this variables stack allocated? If yes, they will be GC-ed once the stack is cleaned up.
| var replicasFromCustomPodResources int | ||
| if awr.GenericTemplate.Raw != nil { | ||
| hasContainer, replicas, containers := hasFields(awr.GenericTemplate) | ||
| //Turning off logic to extract resource requirements from containers. | ||
| //hasContainer, replicas, containers := hasFields(awr.GenericTemplate) | ||
| hasContainer := false | ||
| if hasContainer { | ||
| // Add up all the containers in a pod | ||
| for _, container := range containers { | ||
| res := getContainerResources(container, 1) | ||
| podTotalresource = podTotalresource.Add(res) | ||
| } | ||
| // for _, container := range containers { | ||
| // res := getContainerResources(container, 1) | ||
| // podTotalresource = podTotalresource.Add(res) | ||
| // } | ||
| klog.V(8).Infof("[GetListOfPodResourcesFromOneGenericItem] Requested total pod allocation resource from containers `%v`.\n", podTotalresource) | ||
| } else { | ||
| podresources := awr.CustomPodResources | ||
| for _, item := range podresources { | ||
| replicasFromCustomPodResources += item.Replicas | ||
| res := getPodResources(item) | ||
| podTotalresource = podTotalresource.Add(res) | ||
| } | ||
| klog.V(8).Infof("[GetListOfPodResourcesFromOneGenericItem] Requested total allocation resource from 1 pod `%v`.\n", podTotalresource) | ||
| } | ||
|
|
||
| // Addd individual pods to results | ||
| var replicaCount int = int(replicas) | ||
| var replicaCount int = replicasFromCustomPodResources |
There was a problem hiding this comment.
Probably need a walk through of this logic.
| @@ -629,12 +630,12 @@ func (qjrPod *QueueJobResPod) createQueueJobPod(qj *arbv1.AppWrapper, ix int32, | |||
| templateObjMetadata.SetNamespace(qj.Namespace) | |||
| templateObjMetadata.SetOwnerReferences([]metav1.OwnerReference{ | |||
| *metav1.NewControllerRef(qj, queueJobKind), | |||
| },) | |||
| }) | |||
There was a problem hiding this comment.
Was the , intentionally removed?
| Replicas: 1, | ||
| Type: arbv1.ResourceTypeDeployment, | ||
| Template: runtime.RawExtension{ | ||
| DesiredAvailable: 1, |
There was a problem hiding this comment.
I think Replicas still apply here.
| Replicas: 1, | ||
| Type: arbv1.ResourceTypeDeployment, | ||
| Template: runtime.RawExtension{ | ||
| DesiredAvailable: 1, |
There was a problem hiding this comment.
I think Replicas still apply here.
| Replicas: 1, | ||
| Type: arbv1.ResourceTypeDeployment, | ||
| Template: runtime.RawExtension{ | ||
| DesiredAvailable: 1, |
There was a problem hiding this comment.
I think Replicas still apply here.
| Replicas: 1, | ||
| Type: arbv1.ResourceTypeDeployment, | ||
| Template: runtime.RawExtension{ | ||
| DesiredAvailable: 1, |
There was a problem hiding this comment.
I think Replicas still apply here.
| Replicas: 1, | ||
| Type: arbv1.ResourceTypeNamespace, | ||
| Template: runtime.RawExtension{ | ||
| DesiredAvailable: 1, |
There was a problem hiding this comment.
I think Replicas still apply here.
| Replicas: 1, | ||
| Type: arbv1.ResourceTypeStatefulSet, | ||
| Template: runtime.RawExtension{ | ||
| DesiredAvailable: 1, |
There was a problem hiding this comment.
I think Replicas still apply here.
| //force nil so that Go can GC | ||
| m = nil | ||
| spec = nil | ||
| template = nil | ||
| marshal = nil |
There was a problem hiding this comment.
Aren't this variables stack allocated? If yes, they will be GC-ed once the stack is cleaned up.
| // for _, container := range containers { | ||
| // res := getContainerResources(container, 1) | ||
| // podTotalresource = podTotalresource.Add(res) | ||
| // } | ||
| klog.V(8).Infof("[GetListOfPodResourcesFromOneGenericItem] Requested total pod allocation resource from containers `%v`.\n", podTotalresource) |
There was a problem hiding this comment.
This is dead code in the new logic, can't it be removed altogether ?
| @@ -617,6 +628,8 @@ func (gr *GenericResources) IsItemCompleted(awgr *arbv1.AppWrapperGenericResourc | |||
| klog.Errorf("[IsItemCompleted] mapping error from raw object: `%v`", err) | |||
| return false | |||
| } | |||
| //Force nil for go GC | |||
There was a problem hiding this comment.
I don't think this is needed.
| @@ -550,7 +550,8 @@ func (qjrPod *QueueJobResPod) GetPodTemplate(qjobRes *arbv1.AppWrapperResource) | |||
| if !ok { | |||
| return nil, fmt.Errorf("Job resource template item not define as a PodTemplate") | |||
| } | |||
|
|
|||
| //Force nil for go GC | |||
There was a problem hiding this comment.
I don't think this is needed.
No description provided.