-
Notifications
You must be signed in to change notification settings - Fork 96
fix: retain multiplatform manifest list annotations #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retain multiplatform manifest list annotations #1120
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 42.35% 40.51% -1.85%
==========================================
Files 24 24
Lines 3619 3786 +167
==========================================
+ Hits 1533 1534 +1
- Misses 1974 2140 +166
Partials 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9f88210
to
179a92b
Compare
@robert-cronin merged podman pr, a few minor conflicts on this one now. |
Signed-off-by: robert-cronin <[email protected]>
Signed-off-by: robert-cronin <[email protected]>
179a92b
to
2c651e1
Compare
Signed-off-by: robert-cronin <[email protected]>
a37e414
to
7c58eb9
Compare
@sozercan thank you, should be fixed now! |
discussed offline with @robert-cronin about moving annotations to index level, removing |
Signed-off-by: robert-cronin <[email protected]>
39075e5
to
0299747
Compare
@sozercan I've moved the copa specific annotation over to the platform level on both the manifest level and inside the manifest list on the per-platform annotations themselves. Below is an example patched image: manifest list: https://oci.dag.dev/?image=ghcr.io%2Frobert-cronin%2Fnginx%3A1.27.0-patched-annotations |
@robert-cronin i pushed a change to change annotation to |
Signed-off-by: Sertac Ozercan <[email protected]>
d1e29dc
to
b5f5d14
Compare
Sounds good to me, thank you! |
Signed-off-by: robert-cronin <[email protected]> Signed-off-by: Sertac Ozercan <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]> Co-authored-by: Sertac Ozercan <[email protected]> Signed-off-by: ashnamehrotra <[email protected]>
…c#1120) Signed-off-by: robert-cronin <[email protected]> Signed-off-by: Sertac Ozercan <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]> Co-authored-by: Sertac Ozercan <[email protected]> Signed-off-by: Anirudh Narang <[email protected]>
Retain multiplatform manifest list annotations
Add annotation verification to multiplatform integration tests
Closes #1119
Example of patched image now with annotations retained: https://oci.dag.dev/?image=ghcr.io%2Frobert-cronin%2Fnginx%3A1.27.0-patched-annotations