feat(graphql & repodb): add info about signature validity#1344
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andaaron
reviewed
Apr 10, 2023
andaaron
left a comment
andaaron
left a comment
Contributor
There was a problem hiding this comment.
What is the behavior in case we run zot with dynamodb configuration? What would the SignatureSummary contain?
Andreea-Lupu
force-pushed
the
signatures_validity
branch
4 times, most recently
from
April 12, 2023 17:09
8dd7b4c to
08cb7cc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1344 +/- ##
==========================================
+ Coverage 90.82% 90.93% +0.10%
==========================================
Files 99 102 +3
Lines 22177 22604 +427
==========================================
+ Hits 20143 20554 +411
- Misses 1519 1528 +9
- Partials 515 522 +7
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Andreea-Lupu
force-pushed
the
signatures_validity
branch
from
April 19, 2023 14:08
08cb7cc to
d97be30
Compare
Andreea-Lupu
force-pushed
the
signatures_validity
branch
from
April 19, 2023 14:14
d97be30 to
abd6eda
Compare
Andreea-Lupu
force-pushed
the
signatures_validity
branch
from
April 27, 2023 19:03
abd6eda to
af49a02
Compare
Andreea-Lupu
marked this pull request as ready for review
April 27, 2023 19:12
Andreea-Lupu
requested review from
eusebiu-constantin-petu-dbk,
rchincha and
shimish2
as code owners
April 27, 2023 19:13
andaaron
reviewed
Apr 27, 2023
andaaron
left a comment
andaaron
left a comment
Contributor
There was a problem hiding this comment.
Maybe we should wait on this PR until after notation switches to image manifests?
Andreea-Lupu
force-pushed
the
signatures_validity
branch
7 times, most recently
from
May 19, 2023 09:56
f31e03b to
a1387a4
Compare
andaaron
reviewed
May 19, 2023
Andreea-Lupu
force-pushed
the
signatures_validity
branch
2 times, most recently
from
May 19, 2023 17:32
b17b2b9 to
d25f159
Compare
rchincha
reviewed
May 19, 2023
Andreea-Lupu
force-pushed
the
signatures_validity
branch
2 times, most recently
from
May 23, 2023 08:30
d7b410f to
752c671
Compare
Signed-off-by: Andreea-Lupu <andreealupu1470@yahoo.com>
Andreea-Lupu
force-pushed
the
signatures_validity
branch
from
May 23, 2023 20:31
752c671 to
615977a
Compare
andaaron
approved these changes
May 24, 2023
This was referenced May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.