refactor(storage): move storage init from controller to storagefactory#1345
Closed
eusebiu-constantin-petu-dbk wants to merge 1 commit into
Closed
refactor(storage): move storage init from controller to storagefactory#1345eusebiu-constantin-petu-dbk wants to merge 1 commit into
eusebiu-constantin-petu-dbk wants to merge 1 commit into
Conversation
eusebiu-constantin-petu-dbk
requested review from
andaaron,
rchincha and
shimish2
as code owners
April 7, 2023 14:26
eusebiu-constantin-petu-dbk
force-pushed
the
storage_factory
branch
from
April 7, 2023 14:42
6b6b29c to
e52445e
Compare
rchincha
reviewed
Apr 7, 2023
| func compareImageStore(root1, root2 string) bool { | ||
| isSameFile, err := config.SameFile(root1, root2) | ||
| // This error is path error that means either of root directory doesn't exist, in that case do string match | ||
| storeController, err := storagefactory.New(c.Config, linter, c.Metrics, c.Log) |
Contributor
There was a problem hiding this comment.
Really want this to be a storage.New() ... no factory pls.
rchincha
reviewed
Apr 7, 2023
| "zotregistry.io/zot/pkg/storage/s3" | ||
| ) | ||
|
|
||
| func New(config *config.Config, linter common.Lint, metrics monitoring.MetricServer, |
Contributor
There was a problem hiding this comment.
Why not promote this up to pkg/storage/?
Collaborator
Author
There was a problem hiding this comment.
because it needs to import local/s3 for constructors, but at the same time local/s3 needs common code (which needs storage interface).
eusebiu-constantin-petu-dbk
force-pushed
the
storage_factory
branch
3 times, most recently
from
April 10, 2023 15:00
5992869 to
823792f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1345 +/- ##
=======================================
Coverage 90.50% 90.51%
=======================================
Files 97 98 +1
Lines 21503 21509 +6
=======================================
+ Hits 19462 19468 +6
Misses 1526 1526
Partials 515 515
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
storage_factory
branch
from
April 10, 2023 16:24
823792f to
212c28b
Compare
Contributor
|
pkg/storage/types <- all interfaces Remove keyword "factory" pkg/api/controller only calls storage.New(config) |
Contributor
|
Superseded by #1459 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.