fix: removed duplicate structures from service.go and moved them to p…#1436
Merged
Conversation
aokirisaki
requested review from
andaaron,
eusebiu-constantin-petu-dbk and
rchincha
as code owners
May 10, 2023 13:14
aokirisaki
force-pushed
the
response-struct
branch
from
May 10, 2023 13:16
ad1427b to
f3825f0
Compare
andaaron
reviewed
May 10, 2023
rchincha
reviewed
May 10, 2023
Contributor
|
Revert the linter change |
aokirisaki
force-pushed
the
response-struct
branch
3 times, most recently
from
May 11, 2023 14:27
7220e4c to
60d19c6
Compare
Codecov Report
@@ Coverage Diff @@
## main #1436 +/- ##
=======================================
Coverage ? 90.94%
=======================================
Files ? 102
Lines ? 22634
Branches ? 0
=======================================
Hits ? 20584
Misses ? 1528
Partials ? 522
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aokirisaki
force-pushed
the
response-struct
branch
2 times, most recently
from
May 18, 2023 15:30
7e208de to
78399d9
Compare
andaaron
reviewed
May 18, 2023
andaaron
left a comment
andaaron
left a comment
Contributor
There was a problem hiding this comment.
We're on track with this, but I think we can further improve on the ease of use of the structs in common.
andaaron
reviewed
May 18, 2023
andaaron
left a comment
andaaron
left a comment
Contributor
There was a problem hiding this comment.
We're on track with this, but I think we can further improve on the ease of use of the structs in common.
aokirisaki
force-pushed
the
response-struct
branch
2 times, most recently
from
May 24, 2023 13:34
dcfad28 to
0f3e59f
Compare
andaaron
previously approved these changes
May 24, 2023
aokirisaki
force-pushed
the
response-struct
branch
from
May 25, 2023 07:47
0f3e59f to
9f7731e
Compare
andaaron
approved these changes
May 25, 2023
…kg/common Signed-off-by: Ana-Roberta Lisca <ana.kagome@yahoo.com> Signed-off-by: Lisca Ana-Roberta <ana.kagome@yahoo.com>
aokirisaki
force-pushed
the
response-struct
branch
from
May 25, 2023 08:20
9f7731e to
724c4da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kg/common
What type of PR is this?
Which issue does this PR fix:
#1420
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.