fix(storage): handle dedupe disabled in GetAllDedupeReposCandidates()#2533
Merged
andaaron merged 1 commit intoJul 9, 2024
Merged
Conversation
eusebiu-constantin-petu-dbk
force-pushed
the
fix_storage
branch
from
July 9, 2024 10:14
61f0a55 to
9145401
Compare
eusebiu-constantin-petu-dbk
requested review from
andaaron and
rchincha
as code owners
July 9, 2024 10:14
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
- Coverage 92.82% 92.72% -0.10%
==========================================
Files 169 169
Lines 22304 22413 +109
==========================================
+ Hits 20703 20783 +80
- Misses 998 1016 +18
- Partials 603 614 +11 ☔ View full report in Codecov by Sentry. |
andaaron
reviewed
Jul 9, 2024
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
fix_storage
branch
from
July 9, 2024 11:18
9145401 to
debae38
Compare
andaaron
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.