fix: improve output of zot verify#2745
Merged
Merged
Conversation
See project-zot#2744, there are 2 updates: 1. Silence the usage output in case of config verification errors 2. Wrap the error details in all of the zot configuration errors so they are propagated and shown in stdout for `zot verify` We also need to keep logging those message to the zot logs file since the same logic is caled in the `zot serve` use case. Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2745 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 169 169
Lines 30038 30051 +13
=======================================
+ Hits 27660 27672 +12
- Misses 1759 1760 +1
Partials 619 619 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Example based on #2744 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2744, there are 2 updates:
zot verifyWe also need to keep logging those message to the zot logs file since the same logic is called in thezot serveuse case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.