Skip to content

chore: use go1.23 in the build environment of zot container images#2773

Merged
rchincha merged 2 commits into
project-zot:mainfrom
andaaron:go.1.23
Nov 10, 2024
Merged

chore: use go1.23 in the build environment of zot container images#2773
rchincha merged 2 commits into
project-zot:mainfrom
andaaron:go.1.23

Conversation

@andaaron

@andaaron andaaron commented Nov 10, 2024

Copy link
Copy Markdown
Contributor

There is also this issue with the dedupe tests which should not have failed according to the logs:

# {"level":"info","component":"dedupe","goroutine":66,"caller":"zotregistry.dev/zot/pkg/storage/common/common.go:929","time":"2024-11-08T19:03:24.784121491Z","message":"no digests left, finished"}
# {"level":"debug","component":"scheduler","generator":"DedupeTaskGenerator","goroutine":66,"caller":"zotregistry.dev/zot/pkg/scheduler/scheduler.go:481","time":"2024-11-08T19:03:24.784144645Z","message":"generator is done"}
# {"level":"info","digest":"sha256:f56be85fc22e46face30e2c3de3f7fe7c15f8fd7c4e5add29d7f64b87abdaa09","component":"dedupe","goroutine":57,"caller":"zotregistry.dev/zot/pkg/storage/imagestore/imagestore.go:1990","time":"2024-11-08T19:03:24.784176314Z","message":"restoring deduped blobs for digest"}
# {"level":"warn","component":"dedupe","goroutine":57,"caller":"zotregistry.dev/zot/pkg/storage/imagestore/imagestore.go:1896","time":"2024-11-08T19:03:24.784230305Z","message":"failed to find blob in cache, searching it in storage..."}
# {"level":"info","originalBlob":"/zot/alpine1/blobs/sha256/f56be85fc22e46face30e2c3de3f7fe7c15f8fd7c4e5add29d7f64b87abdaa09","component":"dedupe","goroutine":57,"caller":"zotregistry.dev/zot/pkg/storage/imagestore/imagestore.go:1906","time":"2024-11-08T19:03:24.785769422Z","message":"found original blob"}
# {"level":"info","digest":"sha256:f56be85fc22e46face30e2c3de3f7fe7c15f8fd7c4e5add29d7f64b87abdaa09","component":"dedupe","goroutine":57,"caller":"zotregistry.dev/zot/pkg/storage/imagestore/imagestore.go:2031","time":"2024-11-08T19:03:27.130968035Z","message":"restoring deduped blobs for digest finished successfully"}
# {"level":"debug","component":"scheduler","worker":2,"task":"{Name: DedupeTask, digest: sha256:f56be85fc22e46face30e2c3de3f7fe7c15f8fd7c4e5add29d7f64b87abdaa09, dedupe: false}","goroutine":57,"caller":"zotregistry.dev/zot/pkg/scheduler/scheduler.go:157","time":"2024-11-08T19:03:27.131015424Z","message":"finished task"}
# Last output:
# timeout of 5m reached. unable to find 'no digests left, finished' in '/tmp/bats-run-zXthH1/file/0/zot-log-nodedupe.json'

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
Looks like the message is actually there even if the test fails, maybe there is a timing issue.
https://github.com/project-zot/zot/actions/runs/11747889146/job/32730772641

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
@andaaron
andaaron marked this pull request as ready for review November 10, 2024 08:20
@andaaron
andaaron requested a review from rchincha as a code owner November 10, 2024 08:20
@codecov

codecov Bot commented Nov 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (c991491) to head (efa5491).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2773   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         170      170           
  Lines       30124    30124           
=======================================
  Hits        27695    27695           
  Misses       1806     1806           
  Partials      623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchincha rchincha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha
rchincha merged commit dc38113 into project-zot:main Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants