fix(sync): fixed checking updates in remote tags digest#3156
Merged
rchincha merged 1 commit intoMay 20, 2025
Merged
Conversation
eusebiu-constantin-petu-dbk
force-pushed
the
sync_preserve_digest_fix
branch
from
May 15, 2025 16:40
7c4c0ba to
edb43ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
==========================================
+ Coverage 90.51% 90.55% +0.03%
==========================================
Files 182 182
Lines 32788 32810 +22
==========================================
+ Hits 29678 29711 +33
+ Misses 2348 2330 -18
- Partials 762 769 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andaaron
previously approved these changes
May 15, 2025
eusebiu-constantin-petu-dbk
force-pushed
the
sync_preserve_digest_fix
branch
from
May 15, 2025 20:20
edb43ff to
f0a9b1f
Compare
Contributor
|
Can we do something about code coverage? |
andaaron
reviewed
May 18, 2025
when preserveDigest option in sync is enabled closes: project-zot#3129 Signed-off-by: Eusebiu Petu <petu.eusebiu@gmail.com>
eusebiu-constantin-petu-dbk
force-pushed
the
sync_preserve_digest_fix
branch
from
May 19, 2025 20:20
f0a9b1f to
3eaee7e
Compare
andaaron
approved these changes
May 20, 2025
rchincha
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when preserveDigest option in sync is enabled
closes: #3129
What type of PR is this?
bug fix
Which issue does this PR fix:
#3129
What does this PR do / Why do we need it:
When preserve digest was enabled it didn't correctly compare the local and remote digest when checking if updates were pushed(ie: latest tag was updated) on remote tags.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Added test case
Will this break upgrades or downgrades?
no
Does this PR introduce any user-facing change?:
no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.