fix: parse public key as fallback for certificate for bearer authentication#3180
Conversation
Signed-off-by: evanebb <git@evanus.nl>
|
@evanebb pls take a look at the ci failures. Thx for getting this PR started. |
Signed-off-by: evanebb <git@evanus.nl>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3180 +/- ##
==========================================
+ Coverage 90.57% 90.60% +0.02%
==========================================
Files 182 182
Lines 32827 32836 +9
==========================================
+ Hits 29734 29752 +18
+ Misses 2325 2320 -5
+ Partials 768 764 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@rchincha the CI failures (at least the testing workflow) just seemed to be flaky tests, given that two runs failed at a different point, and the latest run went fine without me changing anything in those places:
The only blocker is Codecov complaining about 0.10% of missing patch coverage, I'll try to bump it up that last bit but you're of course free to bypass it if you want to :) |
What type of PR is this?
bug
Which issue does this PR fix:
#3173
Testing done on this change:
Added automated test cases to check whether supplying RSA/ED/EC public keys instead of certificates works as expected.
Additionally, I spun up a local Zot instance and handed it an RSA public key (not a certificate), and verified that bearer authentication works as expected.
Automation added to e2e:
Will this break upgrades or downgrades?
Nope.
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.