Skip to content

feat(oidc): support per-issuer CA#3760

Merged
andaaron merged 1 commit into
project-zot:mainfrom
matheuscscp:oidc-ca
Feb 1, 2026
Merged

feat(oidc): support per-issuer CA#3760
andaaron merged 1 commit into
project-zot:mainfrom
matheuscscp:oidc-ca

Conversation

@matheuscscp

Copy link
Copy Markdown
Contributor

Closes: #3757

@matheuscscp
matheuscscp marked this pull request as ready for review February 1, 2026 13:07
@codecov

codecov Bot commented Feb 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.60%. Comparing base (b905528) to head (380c43c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/bearer_oidc.go 87.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3760      +/-   ##
==========================================
- Coverage   91.61%   91.60%   -0.01%     
==========================================
  Files         189      189              
  Lines       26926    26930       +4     
==========================================
+ Hits        24668    24670       +2     
- Misses       1459     1460       +1     
- Partials      799      800       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matheuscscp

Copy link
Copy Markdown
Contributor Author

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review. ✅ Project coverage is 91.60%. Comparing base (b905528) to head (38bbab6).

Files with missing lines Patch % Lines
pkg/api/bearer_oidc.go 86.95% 1 Missing and 2 partials ⚠️
Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3760      +/-   ##
==========================================
- Coverage   91.61%   91.60%   -0.01%     
==========================================
  Files         189      189              
  Lines       26926    26930       +4     
==========================================
+ Hits        24668    24670       +2     
- Misses       1459     1460       +1     
- Partials      799      800       +1     

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

The uncovered lines in question are:

+ 		defaultTransport, ok := http.DefaultTransport.(*http.Transport)
+ 		if !ok {
+ 			return nil, fmt.Errorf("%w: failed to get default HTTP transport", zerr.ErrBadConfig)
+ 		}

and

+ 	if hc := o.httpClient; hc != nil {
  		ctx = oidc.ClientContext(ctx, hc)
  	}

The first one cannot be covered since http.DefaultTransport is always *http.Transport, and the second one is covered in the e2e nightly tests.

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@andaaron
andaaron merged commit c8fae88 into project-zot:main Feb 1, 2026
40 of 44 checks passed
@matheuscscp
matheuscscp deleted the oidc-ca branch February 1, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Per-issuer CA in OIDC workload identity federation

2 participants