Skip OCI conversion for already-synced images#3824
Merged
andaaron merged 2 commits intoFeb 28, 2026
Merged
Conversation
When syncRef determines an image is already synced, it now returns a bool to signal the skip. syncImage checks this and returns early before attempting OCI conversion, preventing misleading 'failed to convert docker image to oci' errors caused by a non-existent temp directory.
andaaron
reviewed
Feb 27, 2026
Address review feedback: new referrers can be added upstream after initial sync, so we must not skip syncReferrers. Only the OCI conversion is guarded by the skipped flag, since converting an already-stored image is both unnecessary and incorrect. Signed-off-by: Ugur Tafrali <ugur.tafrali@gmail.com>
andaaron
approved these changes
Feb 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3824 +/- ##
==========================================
- Coverage 91.46% 91.45% -0.02%
==========================================
Files 193 193
Lines 27456 27456
==========================================
- Hits 25113 25109 -4
- Misses 1519 1523 +4
Partials 824 824 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have syncRef return a boolean flag to indicate if an image was skipped. The caller can then return early without attempting OCI conversion, which was causing misleading errors. Fixes #3823.