Skip to content

Multipart download enhancements #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andaaron merged 2 commits into from
Apr 28, 2026
Merged

Multipart download enhancements #4021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa8515f
fix(api): set blob response Content-Type from OCI descriptor
andaaron Apr 27, 2026
c2987f6
perf(api): stream multipart blob ranges lazily with precomputed Conte…
andaaron Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/api/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11247,6 +11247,10 @@ func TestPullRange(t *testing.T) {
So(err, ShouldBeNil)
So(resp.Header().Get("Accept-Ranges"), ShouldEqual, "bytes")
So(resp.StatusCode(), ShouldEqual, http.StatusOK)
// HEAD on an unreferenced blob (no manifest/index) must still
// advertise a valid Content-Type. The descriptor lookup fails
// here, so we expect the application/octet-stream fallback.
So(resp.Header().Get("Content-Type"), ShouldEqual, "application/octet-stream")
})

Convey("Get a range of bytes", func() {
Expand All @@ -11255,6 +11259,11 @@ func TestPullRange(t *testing.T) {
So(resp.StatusCode(), ShouldEqual, http.StatusPartialContent)
So(resp.Header().Get("Content-Length"), ShouldEqual, strconv.Itoa(len(content)))
So(resp.Body(), ShouldResemble, content)
// Single-range 206: descriptor lookup fails (blob is not
// referenced by any manifest), so Content-Type falls back to
// application/octet-stream rather than echoing the request
// Accept header.
So(resp.Header().Get("Content-Type"), ShouldEqual, "application/octet-stream")

resp, err = resty.R().SetHeader("Range", "bytes=0-100").Get(blobLoc)
So(err, ShouldBeNil)
Expand Down Expand Up @@ -11318,6 +11327,11 @@ func TestPullRange(t *testing.T) {
part, err := multipartReader.NextPart()
So(err, ShouldBeNil)
So(part.Header.Get("Content-Range"), ShouldEqual, "bytes 0-1/10")
// Per-part Content-Type reflects the descriptor-aware
// resolution. For an unreferenced blob this is the
// application/octet-stream fallback; for a real OCI layer it
// would carry the manifest's layer media type.
So(part.Header.Get("Content-Type"), ShouldEqual, "application/octet-stream")

partBody, err := io.ReadAll(part)
So(err, ShouldBeNil)
Expand All @@ -11326,6 +11340,7 @@ func TestPullRange(t *testing.T) {
part, err = multipartReader.NextPart()
So(err, ShouldBeNil)
So(part.Header.Get("Content-Range"), ShouldEqual, "bytes 4-6/10")
So(part.Header.Get("Content-Type"), ShouldEqual, "application/octet-stream")

partBody, err = io.ReadAll(part)
So(err, ShouldBeNil)
Expand Down
Loading
Loading